fix: rudder trim text position #3448

Snapmatics · 2021-02-09T19:08:58Z

Summary of Changes

The following PR fixes the position for the Rudder Trim display.

Rudder Trim

Discord Username: Snapmatics#0001

Testing Instructions

Turn ON external power
Check if the Rudder Trim text position is fixed

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created and uploaded.
The build script will have already been run with the latest changes, so no need to rerun it once you download the zip.

Make sure you are signed in to GitHub
Click on the Checks tab on the PR
On the right side, click on the Artifacts drop down and click the A32NX link

ko-zone

LGTM

pepperoni505

If it's possible, can you use an .SVG instead of a .PNG

ExampleWasTaken · 2021-02-09T21:37:41Z

Category: QA Trial
Name: ExampleWasTaken#0886
Date of testing: 9/2/2021
Version of the sim: 1.12.13.0
PR Tested: #3448
Tier of testing: 1
Changes to observe:
fix: chronometer and rudder trim text position + backlight

Testing technique:
Steps you've made to test the Pull Request:

Loaded C&D at night
Powered up
Turned main panel integrated lights on
Checked chronometer and rudder display
Changed time to day
Turned off integrated lights
Checked chronometer and rudder display

Flight notes (When done a full flight): N/A

Media:

Issues (If Any): N/A

Overall Rating: Good
Conclusions of the testing: Works as described

cianwhite · 2021-02-09T21:51:11Z

Category: QA Tester
Name: Cian#3596
Date of testing: 09/02/21
Version of the sim: 1.12.13.0
PR Tested: #3448
Tier of testing: 1
Changes to observe: Lighting changes in Chrono and Rudder Trim
(Insert the Summary of changes, in order to remind what is to test)

Testing technique: Started on the runway at KJFK
Steps you've made to test the Pull Request:

Started on runway 04R at KJFK
Observed rudder trim changes at day
Observed chrono changes at day
Observed rudder trim changes at night
Observed chrono changes at night

Flight notes (When done a full flight): N/A

Media:

Issues (If Any): None

Overall Rating: Good
Conclusions of the testing: Lighting changes work as outlined. LGTM

starvingjavi · 2021-02-11T16:30:45Z

Category: QA Tester
Name: Javi#2557
Date of testing: 11/02/21
Version of the sim: 1.12.13.0
PR Tested: #3448
Tier of testing: 1
Changes to observe: Changes to the numbers in Chrono and Rudder Trim, lighting and position

Testing technique: Started on gate on MMAA and changed lighting conditions
Steps you've made to test the Pull Request:

Started on ramp in MMAA
Start airplane to get electrical power
Check lighting on chronometer numbers during day and night
Check lighting and position of rudder trim numbers during day and night

Flight notes (When done a full flight): N/A

Media:

Issues (If Any): None

Overall Rating: Good
Conclusions of the testing: LGTM

theflyingexpert · 2021-02-11T18:09:52Z

Category: QA Tester/Trial
Name: Discord User #5118
Date of testing: Current date 11/02/2021
Version of the sim: 1.12.13.0
PR Tested: #3448
Tier of testing: 1
Changes to observe: Lighting changes in Chrono and Rudder Trim

Testing technique: Description of how you tested the Pull Request
Steps you've made to test the Pull Request:

Started A32NX cold & dark (daytime)
Turned external power ON
Checked chronometer text position
Checked rudder trim text position
Set night time
Checked chronometer backlight

Flight notes (When done a full flight): -

Media:

Issues (If Any): Write any issues
Steps to achieve the issue

Overall Rating: Good
Conclusions of the testing: -

HugoTro · 2021-02-12T11:40:08Z

Category: QA Tester
Name: Hugo #3307
Date of testing: Current date 12/02/2021
Version of the sim: 1.12.13.0
PR Tested: #3448
Tier of testing: 1
Changes to observe: chronometer & rudder trim text position & backlight

Testing technique: Look-at
Steps you've made to test the Pull Request:

Spawned in C&D and powered up the aircraft
Looked at chronometer & rudder trim in the day
Looked at chronometer & rudder trim in the night with backlight

Media:

Issues (If Any): None
Steps to achieve the issue

Overall Rating: Good
Conclusions of the testing: LGTM 👍

bbelliot · 2021-02-12T15:02:32Z

Category: QA Trial
Name: Elliot#7195
Date of testing: Current date DD/MM/YYYY
Version of the sim: 1.12.13.0
PR Tested: #3448
Tier of testing: 1
Changes to observe: Changed Chrono and Rudder positions and backlights

Testing technique: Look at
Steps you've made to test the Pull Request:

Loaded onto a gate cold and dark - Night time on a dark stand
Checked the backlight on the chronometer after turning batt & external power one
Compared new positioning to old positioning
Changed time to day
Checked backlight still visible

Flight notes (When done a full flight): N/A

Media:

Issues (If Any): None to note
Steps to achieve the issue

Overall Rating: Good
Conclusions of the testing: Ready to be merged to master

marcman86 · 2021-02-13T16:06:56Z

Name: marcman86#4907
Date of testing: 13.2.2021
Version of the sim: 1.12.13.0
PR Tested: #3448
Tier of testing: 1
Changes to observe: Position of trim and chronometer values. LCD style backlight.
Testing technique: Tryout

Steps you've made to test the Pull Request:

1.) Spawn at day C&D EDDP
2.) Without power trim and chrono display (backlights) are not turning on.
3.) Turned on Bat. This turns on both displays. Backlight barely visible (good).
4.) Set time to night. Backlight becomes more visible (Image1, Image2).

Media:

Image1

Image2

Issues (If Any): None

Overall Rating: Good

Conclusions of the testing: Nice backlight, value positions fits the displays.

Hope this helps :-)

pepperoni505 · 2021-02-13T19:28:54Z

Holding back on merging until you switch to an .svg

Snapmatics · 2021-02-13T19:35:05Z

Holding back on merging until you switch to an .svg

Roger, you are also free to convert it to a draft PR until I switch it over to a .svg.

Snapmatics · 2021-02-14T10:03:36Z

Holding back on merging until you switch to an .svg

I was told that the 3 dots that the backlight has are not visible for pilots but only via a camera. I will be deleting it, and I will keep the fix for the Rudder Trim position text. + The text's positioning for the chronometer has slightly been improved by Tyler by adding the new font (good job by him). 👍

Whenever you feel this PR is ready, you can open it and merge it. (At least the rudder trim text has been tested)

pepperoni505

LGTM

pepperoni505 · 2021-02-15T04:08:59Z

I'd like to get one more QA test in before we merge

Snapmatics · 2021-02-15T04:10:16Z

I'd like to get one more QA test in before we merge

Roger, thanks for reviewing again. 🤝

marcman86 · 2021-02-15T10:09:52Z

Name: marcman86#4907
Date of testing: 15.2.2021
Version of the sim: 1.12.13.0
PR Tested: #3448
Tier of testing: 1
Changes to observe: Rud Trim digit position
Testing technique: Tryout

Steps made to test the Pull Request:

1.) Spawned C&D at EDDP
2.) Turned on bat. and ext. power
3.) Looked at Rud Trim display (Image1)
4.) Did ANN LT Test (Image2)

Media:

Image1

Image2

Issues: ANN LT Test not working

Overall Rating: -

Conclusions of the testing: Digits are aligned in the center. If ANN LT is part of this PR please fix.

Hope this helps :-)

Snapmatics · 2021-02-15T11:13:19Z

Name: marcman86#4907
Date of testing: 15.2.2021
Version of the sim: 1.12.13.0
PR Tested: #3448
Tier of testing: 1
Changes to observe: Rud Trim digit position
Testing technique: Tryout

Steps made to test the Pull Request:

1.) Spawned C&D at EDDP
2.) Turned on bat. and ext. power
3.) Looked at Rud Trim display (Image1)
4.) Did ANN LT Test (Image2)

Media:

Image1

Image2

Issues: ANN LT Test not working

Overall Rating: -

Conclusions of the testing: Digits are aligned in the center. If ANN LT is part of this PR please fix.

Hope this helps :-)

Blocked Merge!

Benjozork · 2021-03-11T08:13:15Z

@Snapmatics is this still being worked on?

Snapmatics · 2021-03-11T09:14:06Z

@Snapmatics is this still being worked on?

Yeah it will be pushed together with interior. Just keeping it in another PR.

derl30n · 2021-03-18T20:08:30Z

#3794 has been merged.

Snapmatics added 3 commits February 9, 2021 21:01

Add files via upload

d2ba7dd

fix: chronometer placement

02620b3

fix: rudder trim text position

b279fd6

ko-zone approved these changes Feb 9, 2021

View reviewed changes

ko-zone added QA Tier 1 Ready to Test labels Feb 9, 2021

ko-zone and others added 2 commits February 9, 2021 21:23

Merge branch 'master' into Chronometer-RudderTrim-Text

b79358f

Merge branch 'master' into Chronometer-RudderTrim-Text

b7d7cd7

pepperoni505 suggested changes Feb 9, 2021

View reviewed changes

Benjozork added this to the v0.6.0 milestone Feb 10, 2021

Darlack6 mentioned this pull request Feb 12, 2021

feat: coffee cup #3479

Merged

pepperoni505 added Do Not Merge Tested and removed Ready to Test labels Feb 13, 2021

Merge branch 'master' into Chronometer-RudderTrim-Text

253596e

pepperoni505 marked this pull request as draft February 13, 2021 19:43

marcman86 mentioned this pull request Feb 13, 2021

fix: hide colon when chrono stopped (#3237) #3469

Merged

Snapmatics added 3 commits February 14, 2021 12:04

delete backlight

5e05d38

delete: main backlight

370a99f

fix: reverting changes for chrono

ce5f2c0

Snapmatics changed the title ~~fix: chronometer and rudder trim text position + backlight~~ fix: rudder trim text position Feb 14, 2021

Merge branch 'master' into Chronometer-RudderTrim-Text

fff9535

pepperoni505 marked this pull request as ready for review February 15, 2021 04:08

pepperoni505 approved these changes Feb 15, 2021

View reviewed changes

Merge branch 'master' into Chronometer-RudderTrim-Text

18c2717

Merge branch 'master' into Chronometer-RudderTrim-Text

e716854

Snapmatics marked this pull request as draft February 15, 2021 11:13

beheh mentioned this pull request Mar 4, 2021

feat: React Chrono, BAT indicator, rudder trim indicator #3794

Merged

8 tasks

Benjozork added the Waiting For Response This issue or PR needs a response from the author label Mar 11, 2021

derl30n removed this from the v0.6.0 milestone Mar 17, 2021

This comment has been minimized.

Sign in to view

Snapmatics closed this Apr 13, 2021

pepperoni505 deleted the Chronometer-RudderTrim-Text branch April 13, 2021 14:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: rudder trim text position #3448

fix: rudder trim text position #3448

Snapmatics commented Feb 9, 2021 •

edited

Loading

ko-zone left a comment

pepperoni505 left a comment

ExampleWasTaken commented Feb 9, 2021

cianwhite commented Feb 9, 2021 •

edited

Loading

starvingjavi commented Feb 11, 2021

theflyingexpert commented Feb 11, 2021 •

edited

Loading

HugoTro commented Feb 12, 2021

bbelliot commented Feb 12, 2021

marcman86 commented Feb 13, 2021

pepperoni505 commented Feb 13, 2021

Snapmatics commented Feb 13, 2021

Snapmatics commented Feb 14, 2021 •

edited

Loading

pepperoni505 left a comment

pepperoni505 commented Feb 15, 2021

Snapmatics commented Feb 15, 2021

marcman86 commented Feb 15, 2021

Snapmatics commented Feb 15, 2021

Benjozork commented Mar 11, 2021

Snapmatics commented Mar 11, 2021

This comment has been minimized.

derl30n commented Mar 18, 2021

fix: rudder trim text position #3448

fix: rudder trim text position #3448

Conversation

Snapmatics commented Feb 9, 2021 • edited Loading

Summary of Changes

Rudder Trim

Testing Instructions

How to download the PR for QA

ko-zone left a comment

Choose a reason for hiding this comment

pepperoni505 left a comment

Choose a reason for hiding this comment

ExampleWasTaken commented Feb 9, 2021

cianwhite commented Feb 9, 2021 • edited Loading

starvingjavi commented Feb 11, 2021

theflyingexpert commented Feb 11, 2021 • edited Loading

HugoTro commented Feb 12, 2021

bbelliot commented Feb 12, 2021

marcman86 commented Feb 13, 2021

pepperoni505 commented Feb 13, 2021

Snapmatics commented Feb 13, 2021

Snapmatics commented Feb 14, 2021 • edited Loading

pepperoni505 left a comment

Choose a reason for hiding this comment

pepperoni505 commented Feb 15, 2021

Snapmatics commented Feb 15, 2021

marcman86 commented Feb 15, 2021

Snapmatics commented Feb 15, 2021

Benjozork commented Mar 11, 2021

Snapmatics commented Mar 11, 2021

This comment has been minimized.

derl30n commented Mar 18, 2021

Snapmatics commented Feb 9, 2021 •

edited

Loading

cianwhite commented Feb 9, 2021 •

edited

Loading

theflyingexpert commented Feb 11, 2021 •

edited

Loading

Snapmatics commented Feb 14, 2021 •

edited

Loading