Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bring in a380x instruments @2dc636d7 #8289

Merged
merged 9 commits into from
Nov 12, 2023

Conversation

tracernz
Copy link
Member

@tracernz tracernz commented Nov 7, 2023

Fixes #[issue_no]

Summary of Changes

Brings instruments from flybywiresim/a380x@2dc636d7 into the monorepo.

Build scripts and imports have been adjusted for the monorepo environment.

TODO:

  • Reconcile the two different A380X simvar files in the two repos
  • Fix or disable A380X lint as it does not pass in the A380X repo either... :/
  • Disable fms-v2 tests in fbw-a380x as they fail even on fms-v2 branch
  • PR to remove all the instrument code from the A380X repo
  • Raise issues to fix A380X lint and tests
  • Raise issue to delete msfs-navdata dep after fms-v2 merge (it is integrated in the monorepo in that branch)

Screenshots (if necessary)

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  • Perform a quick smoke test of the A320

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

Build scripts and imports have been adjusted for the monorepo
environment.

Co-authored-by: Sven Czarnian <devel@svcz.de>
Co-authored-by: Benjamin Dupont <benjozorkfr@gmail.com>
Co-authored-by: Richard Pilbery <email@pilbery.co.uk>
Co-authored-by: Benedict Etzel <developer@beheh.de>
Co-authored-by: svengcz <64070348+svengcz@users.noreply.github.com>
Co-authored-by: BBK <22713769+BlueberryKing@users.noreply.github.com>
Co-authored-by: ErickSharp <titaninmc@gmail.com>
Co-authored-by: 2hwk <reasonstouninstall@tutanota.com>
Co-authored-by: Nufflee <zifcani@gmail.com>
Co-authored-by: davydecorps <38904654+crocket63@users.noreply.github.com>
Co-authored-by: Crock <38904654+crocket63@users.noreply.github.com>
Co-authored-by: Taz5150 <roldan5150@gmail.com>
Co-authored-by: crocket63 <38904654+crocket63@users.noreply.github.com>
@tracernz tracernz changed the title chore: bring in a380 instruments @2dc636d7 chore: bring in a380x instruments @2dc636d7 Nov 7, 2023
@alepouna
Copy link
Member

QA Report

Discord: alepouna
Object of testing: #8289
Tier of Testing: 2
Date: 12/11/2023

Testing Process:

  • Performed a full flight, test various systems in-flight, performed a GA and an autoland as well.

Notes:

  • Could be completely irrelevant from this PR (have not tested in dev/other branches due to lack of time) but the APU if it was running and goes to FAULT due to lack of fuel the EGT remains at a high 560C without any drops even if the N1. I do not consider this to be an issue with the PR but worth noting.

Testing Results:
Passed

@Benjozork Benjozork enabled auto-merge (squash) November 12, 2023 11:38
@Benjozork Benjozork merged commit e1bf51e into flybywiresim:master Nov 12, 2023
6 checks passed
@2hwk 2hwk added this to the v0.11.2 milestone Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✔️ Done
Development

Successfully merging this pull request may close these issues.

4 participants