Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(fms): fms-v2 aircraft specific config / VNAV parameters #8493

Merged
merged 555 commits into from
Jul 1, 2024
Merged

feat(fms): fms-v2 aircraft specific config / VNAV parameters #8493

merged 555 commits into from
Jul 1, 2024

Conversation

flogross89
Copy link
Contributor

@flogross89 flogross89 commented Feb 15, 2024 •
edited
Loading

Summary of Changes

  • Introduces A380 specific engine and flight model parameters to enable VNAV (predictions).
  • Includes changes to fms-v2 to enable TS strict mode compliance for the MFD
  • Adds units to JSDoc in FlightPlanPerformanceData
  • Change representation of not-set values from undefined to null (also improves behavior when using event bus sync)

Screenshots (if necessary)

n/a

References

Additional context

Discord username (if different from GitHub): floridude

Testing instructions

For A320: Should behave exactly as before, no change expected. Pay attention to VNAV predictions and vertical guidance, e.g. during approach
For A380: Testing being done separately

How to download the PR for QA

Every new commit to this PR will cause a new A32NX artifact to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, click on the bottom PR tab
  4. Click on the A32NX download link at the bottom of the page

BlueberryKing and others added 30 commits January 26, 2024 21:58
@BlueberryKing
Deduplicate waypoints when inserting into flightplan
ba41654
@BlueberryKing
Fix origin being active leg initially
76bc206
@BlueberryKing
Add IF for procedures starting with FX
3352127
@BlueberryKing
Implement FROM/TO leg deletion
07a4834
@flogross89
fix: fms-v2 fmgc variable ref (flybywiresim#8376)
e6609fe 
fix(fms-v2): don't require explicit Fmgc namespace reference when calling fmgc's DataManager
@BlueberryKing
Always compute IF at runway/airport
0ffc721
@BlueberryKing
Merge branch 'fms-v2' of https://github.com/flybywiresim/aircraft int…
3cb41ca 
…o fms-v2
@BlueberryKing
Only restring to enroute if arrival changed
72b262c
@BlueberryKing
Fix arrival not being rebuilt for transition change
7c61201
@BlueberryKing
Reset enroute transition when arrival changes
7408d51
@BlueberryKing
Show ILS frequency on Arrivals page
cafdd42
@BlueberryKing
Set active leg when arrival changes while flying it
3d01124
@BlueberryKing
Deduplicate after airway entry
ccb1ca9
@BlueberryKing
Create disco but no tmpy on waypoint entry
e16e3d2
@BlueberryKing
Fix missing approach vias with Navigraph data
d31c219
@BlueberryKing
Remove MagVar class
4380fca
@BlueberryKing
Fix no disco for waypoint insertion before destination
702cdc2
@BlueberryKing
Fix being able to clear PPOS
61f5d09
@Saschl
fix: cleanup docker images for more space
548ad23
@BlueberryKing
Remove deleted import
19722e6
@BlueberryKing
Merge branch 'fms-v2' of https://github.com/flybywiresim/aircraft int…
5a76afd 
…o fms-v2
@BlueberryKing
Improve airway entry perf by filtering at db level
e9d385d
@BlueberryKing
Fix typo in constraint parsing
20bb626
@BlueberryKing
Port AIRPORT key functionality
42a95f9
@BlueberryKing
Remove unnecessary navdata workaround
50e7eb4
@BlueberryKing
Remove accidental CSS changes
2b14603
@BlueberryKing
Use 0 as default origin altitude
8998ae4
@BlueberryKing
Rename to more meaningful name
6cf601d
@BlueberryKing
Only transmit fixinfos of active flightplan
b49986b
@BlueberryKing
Treat "at" speed constraints as "atOrBelow"
027e4c2
@flogross89 flogross89 added A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft and removed Do Not Merge Not Ready For Testing Not ready for testing as still being discussed or developed. labels Jun 15, 2024
tracernz
tracernz requested changes Jun 15, 2024
View reviewed changes
fbw-a32nx/src/systems/fmgc/src/guidance/GuidanceController.ts Outdated Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/CostIndex.ts Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/EngineModel.ts Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/flightplanning/new/A380AircraftConfig.ts Outdated Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/DescentStrategy.ts Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/TacticalDescentPathBuilder.ts Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/takeoff/TakeoffPathBuilder.ts Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/navigation/Navigation.ts Outdated Show resolved Hide resolved
Benjozork
Benjozork requested changes Jun 15, 2024
View reviewed changes
Copy link
Member

@Benjozork Benjozork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

fbw-a32nx/src/systems/fmgc/src/flightplanning/new/A320AircraftConfig.ts Outdated Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/flightplanning/new/A380AircraftConfig.ts Outdated Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/CostIndex.ts Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/EngineModel.ts Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/climb/ClimbPathBuilder.ts Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/DescentStrategy.ts Outdated Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/descent/TacticalDescentPathBuilder.ts Outdated Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/guidance/vnav/takeoff/TakeoffPathBuilder.ts Outdated Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/index.ts Show resolved Hide resolved
fbw-a32nx/src/systems/fmgc/src/flightplanning/new/AircraftConfigInterface.ts Outdated Show resolved Hide resolved
@flogross89
Copy link
Contributor Author

@tracernz @Benjozork thanks for the review! Last commits should address all your remarks

@flogross89 flogross89 mentioned this pull request Jun 17, 2024
Merged
@flogross89
[VNAV] a32nx fixes
7f23f70 
(cherry picked from commit 8c68638)
@flogross89
Merge branch 'master' into a380x-experimental
8f88e68 
# Conflicts:
#	fbw-a32nx/src/systems/fmgc/src/flightplanning/new/plans/performance/FlightPlanPerformanceData.ts
#	fbw-common/src/systems/shared/src/MathUtils.ts
@flogross89
Merge branch 'master' into feat-fms-v2-aircraft-config-2
b262aad
@alepouna
Copy link
Member

QA Report

Discord: alepouna
Object of testing: #8493
Tier of Testing: 2
Date: 29/6/2024

Testing Process:

  • Perform full flights, observe no VNAV prediction issues or vertical guidance issues

Testing Results:
Passed

@Saschl
Copy link
Contributor

Saschl commented Jul 1, 2024

QA Report

Discord: Saschl
Object of testing: #8493
Tier of Testing: 2
Date: 01/07/2024

Testing Process:

Full flight LOWI - EDDF.

Observed VNAV profile and guidance, could not see regressions. LGTM

Testing Results:
Passed

@flogross89 flogross89 merged commit dfdb439 into flybywiresim:master Jul 1, 2024
7 checks passed
@flogross89 flogross89 deleted the feat-fms-v2-aircraft-config-2 branch July 27, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BlueberryKing BlueberryKing BlueberryKing approved these changes

@tracernz tracernz tracernz approved these changes

@Benjozork Benjozork Benjozork approved these changes

Assignees
No one assigned
Labels
A32NX Related to the A32NX aircraft A380X Related to the A380X aircraft QA Passed QA Ready to Test
Projects
Quality Assurance
Status: ✔️ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@flogross89 @2hwk @alepouna @Saschl @Benjozork @tracernz @BlueberryKing @aguther @crocket63 @frankkopp