-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Improved expedited presets with quick ADIRS/APU/ENG start/stop #8581
Merged
frankkopp
merged 67 commits into
flybywiresim:master
from
frankkopp:presets-expedite-fadec-apu
Sep 15, 2024
Merged
feat: Improved expedited presets with quick ADIRS/APU/ENG start/stop #8581
frankkopp
merged 67 commits into
flybywiresim:master
from
frankkopp:presets-expedite-fadec-apu
Sep 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tracernz
reviewed
Mar 25, 2024
tracernz
reviewed
Mar 25, 2024
fbw-common/src/wasm/systems/systems/src/apu/electronic_control_box.rs
Outdated
Show resolved
Hide resolved
frankkopp
force-pushed
the
presets-expedite-fadec-apu
branch
8 times, most recently
from
April 2, 2024 14:36
85e3373
to
5a9dab3
Compare
frankkopp
force-pushed
the
presets-expedite-fadec-apu
branch
4 times, most recently
from
April 13, 2024 16:30
8545e2d
to
460f6c8
Compare
frankkopp
force-pushed
the
presets-expedite-fadec-apu
branch
3 times, most recently
from
April 19, 2024 15:09
52e635c
to
1d4c7f0
Compare
frankkopp
added
Needs Code Review
and removed
Not Ready For Review
Still draft but needs a GitHub build
labels
Apr 19, 2024
2hwk
requested changes
Apr 20, 2024
.../html_ui/Pages/VCockpit/Instruments/Airliners/FlyByWire_A320_Neo/FMC/A32NX_FMCMainDisplay.js
Outdated
Show resolved
Hide resolved
frankkopp
force-pushed
the
presets-expedite-fadec-apu
branch
from
April 21, 2024 11:09
1d4c7f0
to
4d11d8b
Compare
2hwk
approved these changes
Apr 23, 2024
…gacy LVars without prefix
…h of vars - code now checks if prefix is already present
frankkopp
force-pushed
the
presets-expedite-fadec-apu
branch
from
September 15, 2024 08:11
fdd6650
to
9bf0cb6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Improve the expedited quick Aircraft Preset loading with making ADIRS/APU/ENG starting and stopping instantly.
Major changes
Additional changes:
Discord username (if different from GitHub): cdr_maverick
Screenshots / Video
2024-04-14_16h06_15.mp4
Testing instructions
A32NX:
Test all possible combinations of presets and presets sequences.
Test expedited or normal speed - even mix or change while loading
Regression Test and check normal operation without using presets and ensure this has not regressed in any way.
Check:
not fail QA
Try to break it :D
Also check for regressions - there have been some changes to the ADIRS, APU, FADEC, flaps/slats code to make these instant or near-instant. So a full flight is recommended where these systems are also monitored/checked for any issues.
A380X:
Same but with less priority
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.