fix(a380x/efb): Fixed window handle being clickable through flyPad Screen #9496
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9328
Fixes #9279
Fixes #9186
Fixes #9265
Summary of Changes
All these issues were linked to or are suspected to be caused by window handle being able to be clicked through the flyPad EFB screen.
While the previous fixes prevented the window from opening, the clickspot was still active which interfered with the use of certain EFB functions.
This PR adds a definition in the XML that solves this issue.
Note: The previous mitigation that used camera ray collisions is still active, as it is still useful in cases where the user accidentally clicks on the window handle while intending to use the EFB. As this is based on the EFB being in the center of the viewport, we can assume in most cases where the EFB is in such a view that the user intends to use the EFB and not open the window.
Without the camera ray intersection change, clicking through the bezel of the flyPad (outside of the screen) would still activate the window open handle.
Screenshots (if necessary)
References
Additional context
Discord username (if different from GitHub):
Testing instructions
How to download the PR for QA
Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.