Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(a380x/efb): Fixed window handle being clickable through flyPad Screen #9496

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

2hwk
Copy link
Member

@2hwk 2hwk commented Nov 12, 2024

Fixes #9328
Fixes #9279
Fixes #9186
Fixes #9265

Summary of Changes

All these issues were linked to or are suspected to be caused by window handle being able to be clicked through the flyPad EFB screen.

While the previous fixes prevented the window from opening, the clickspot was still active which interfered with the use of certain EFB functions.

This PR adds a definition in the XML that solves this issue.

Note: The previous mitigation that used camera ray collisions is still active, as it is still useful in cases where the user accidentally clicks on the window handle while intending to use the EFB. As this is based on the EFB being in the center of the viewport, we can assume in most cases where the EFB is in such a view that the user intends to use the EFB and not open the window.

Without the camera ray intersection change, clicking through the bezel of the flyPad (outside of the screen) would still activate the window open handle.

Screenshots (if necessary)

image

References

Additional context

Discord username (if different from GitHub):

Testing instructions

  1. Ensure that you are not able to open the window while clicking on the EFB screen
  2. Ensure the window can still be opened when the EFB is not in the center of the view (move the camera slightly more to the side if you are blocked by the EFB still)

How to download the PR for QA

Every new commit to this PR will cause new A32NX and A380X artifacts to be created, built, and uploaded.

  1. Make sure you are signed in to GitHub
  2. Click on the Checks tab on the PR
  3. On the left side, find and click on the PR Build tab
  4. Click on either flybywire-aircraft-a320-neo, flybywire-aircraft-a380-842 (4K) or flybywire-aircraft-a380-842 (8K) download link at the bottom of the page

@2hwk 2hwk changed the title fix(a380x/efb): fix(a380x/efb): Fixed window handle being clickable through flyPad Screen Nov 12, 2024
@beheh beheh added the A380X Related to the A380X aircraft label Nov 12, 2024
@2hwk 2hwk added this to the v0.13.0 milestone Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A380X Related to the A380X aircraft QA Ready to Test QA Tier 1
Projects
Status: 🟣 QA Review: Ready to Test
3 participants