-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: lint and styling overhaul #77
Draft
ExampleWasTaken
wants to merge
87
commits into
flybywiresim:staging
Choose a base branch
from
ExampleWasTaken:ref/lint-overhaul
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
refactor: lint and styling overhaul #77
ExampleWasTaken
wants to merge
87
commits into
flybywiresim:staging
from
ExampleWasTaken:ref/lint-overhaul
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0adefb7.
* disable eslint that exposes bug in shutdown logic
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
As extensively discussed, this PR overhauls all linting and styling rules used in this repository.
Goals
To recap the most important things, the main goals were
Implementation
These goals are achieved by:
recommended
config-presets by ESLint and typescript-eslint.Rule suggestions
Additionally to the recommended preset, I've gone through the available rules and suggest the following additional rules:
no-await-in-loop
no-constructor-return
this
).no-self-compare
no-unreachable-loop
no-console
(warn)I think they are beneficial as they all save time during code reviews as they catch stuff that would most likely end up being questioned during a review anyway.
Additional Details
There are a few more things that are worth mentioning:
Depends on
Soft-depends on