Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(failures): update with generator + images + inline bootstrap icon config #862

Draft
wants to merge 28 commits into
base: primary
Choose a base branch
from

Conversation

Valastiri
Copy link
Member

@Valastiri Valastiri commented Jul 17, 2023

closes: #860

Summary

In support of A32NX PR:

Please reference issue above for more information.

  • Added photoshop PSD into /src that has a basic template for cropping and sizing EFB images to match our style divs if required. (Just a handy inclusion)
  • feat: added config for inline bootstrap icons
  • feat: added to /src for original TAKEOFF icon combined in html

Also scrubbed the idea for a new page as everything was able to live on a single page and prevents a further nested directory.

Current Active List TODO

  • Update + refactor failures page with new title for cleaner slug

Location

Discord username (if different from GitHub): valastiri

@vercel
Copy link

vercel bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 8:35am

@Maverickwoe
Copy link

Maverickwoe commented Jul 17, 2023

Apologies. Due to a request from donstim, I moved the max simultaneous failures setting in all the generators to avoid ambiguity.
Pages now look like this
Altitude
image

@Maverickwoe
Copy link

Maverickwoe commented Jul 17, 2023

Speed
image

@Maverickwoe
Copy link

Probability over time
image

@Maverickwoe
Copy link

Timed failure
image

@Maverickwoe
Copy link

Maverickwoe commented Jul 17, 2023

Take Off
image
Bottom part
image

@Maverickwoe
Copy link

Main page does not display anymore the maximum number of simultaneous failures.
image

@Maverickwoe
Copy link

Maverickwoe commented Jul 24, 2023

Thanks a lot for the page @Valastiri
Can I suggest to

  • update the old images too ? they lack the new tab.
  • mention "corresponding tabs" in the second paragraph ? It would be nice to make the user understand to which "buttons" this relates on the page. Or maybe mention these tabs at the beginning of each chapters "On Demand Failures" and "Failure Generators"
  • "Note: In aviation, rates of failure" : missing the coma
  • Can you add "ground speed" every time speed is mentioned ? all generators are based on ground speed so that gusts do not impact the result.
  • Max Failures and Number of Failures: Can you replace with this text that covers better the recent changes ?
    "Each generator defines a specific number of failures to be triggered at the same time and a maximum number of failure. The number of failures will activate up to the total number of failures on the plane."
  • Could you kindly also add the takeoff diagram in the take off generator ?
    Thanks

here are screenshots for the old pages:
image
image
image
image
image
image

@Valastiri
Copy link
Member Author

Thanks a lot for the page @Valastiri

Can I suggest to

  • update the old images too ? they lack the new tab.

  • mention "corresponding tabs" in the second paragraph ? It would be nice to make the user understand to which "buttons" this relates on the page. Or maybe mention these tabs at the beginning of each chapters "On Demand Failures" and "Failure Generators"

  • "Note: In aviation, rates of failure" : missing the coma

  • Can you add "ground speed" every time speed is mentioned ? all generators are based on ground speed so that gusts do not impact the result.

  • Max Failures and Number of Failures: Can you replace with this text that covers better the recent changes ?

"Each generator defines a specific number of failures to be triggered at the same time and a maximum number of failure. The number of failures will activate up to the total number of failures on the plane."

  • Could you kindly also add the takeoff diagram in the take off generator ?

Thanks

here are screenshots for the old pages:

image

image

image

image

image

image

I'll look into this by tomorrow hopefully. For images I just don't have time to run the sim but I'll try and get the artifact to take some screenies.

docs/fbw-a32nx/feature-guides/flypados3/failures.md Outdated Show resolved Hide resolved
docs/fbw-a32nx/feature-guides/flypados3/failures.md Outdated Show resolved Hide resolved
docs/fbw-a32nx/feature-guides/flypados3/failures.md Outdated Show resolved Hide resolved
docs/fbw-a32nx/feature-guides/flypados3/failures.md Outdated Show resolved Hide resolved
docs/fbw-a32nx/feature-guides/flypados3/failures.md Outdated Show resolved Hide resolved
docs/fbw-a32nx/feature-guides/flypados3/failures.md Outdated Show resolved Hide resolved
@Maverickwoe
Copy link

Thanks for the updates. Looking good so far !
Just noticed maybe an improvement on the text I gave you:
"TAKE OFF : The generator will wait until FL or TOGA thrust is set to arm itself. It will trigger a set of failures only once until another take off event occurs."
Could be improved by
"TAKE OFF : The generator will wait until FL or TOGA thrust is set while on the ground to arm itself. It will trigger a set of failures only once until another take off event occurs."

Up to you.

@Valastiri
Copy link
Member Author

Thanks for the updates. Looking good so far ! Just noticed maybe an improvement on the text I gave you: "TAKE OFF : The generator will wait until FL or TOGA thrust is set to arm itself. It will trigger a set of failures only once until another take off event occurs." Could be improved by "TAKE OFF : The generator will wait until FL or TOGA thrust is set while on the ground to arm itself. It will trigger a set of failures only once until another take off event occurs."

Up to you.

This does sound better I'll make that change in a bit.

I'll batch the images and optimize them for each failure provided the ones you've sent are still valid / current. I haven't had a chance to update my sim or download the artifact so I'm counting on that heh.

As soon as I've gotten the images this should be RTR

@Maverickwoe
Copy link

Maverickwoe commented Aug 12, 2023

Here's a photoshopped combined version of the two pages of settings from take off generator. You will obviously need to scroll to see all of them but might be better for the documentation
image

@Valastiri
Copy link
Member Author

Takeoff diagram will be WIP and may come at a later date. Hopefully can get it branded before a32nx PR is merged

@Valastiri Valastiri changed the title docs(failures): update and create new pages docs(failures): update page with generator + images Aug 14, 2023
@Valastiri Valastiri marked this pull request as ready for review August 14, 2023 06:24
@github-actions github-actions bot added the Review Required PR Check Label label Aug 14, 2023
@github-actions
Copy link

This PR is being prevented from merging because Review Required. Use the Approved label to run build validation and auto merge the PR.

@Maverickwoe
Copy link

Hey @Valastiri
Following the latest updates, could you kindly modify the doc with these elements:
1/ Below the "configuration options".
Could you put something that refers to the two colors of the icon
white:
image
The generator is not armed
blue:
image
The generator is armed
2/ Could you put the corresponding icons next to each options of the "configuration options"
take off
image
off
image
once
image
repeat
image

@Maverickwoe

This comment was marked as duplicate.

@Maverickwoe
Copy link

can you add the button icon in a new section "Failure generator settings" below the section "Failure Pool Selection"
Text would be.
You can access the settings of each failure generator by pressing the icon
https://icons.getbootstrap.com/icons/sliders2-vertical/

@Maverickwoe
Copy link

bigger blue icon
image

@Maverickwoe
Copy link

Can you add in the section "Timed Failure Generator"
Note : The timer is running when the generator mode icon is blue

@Maverickwoe
Copy link

Can you add at the end of the section "Altitude Failure Generator"
The failure generator can only arm itself when the plane is outside of the altitude activation range with an extra margin of 100 feet.
The generator mode icon will therefore stay white if the plane is within the altitude activation range

Can you add at the end of the section "Speed Failure Generator"
The failure generator can only arm itself when the plane is outside of the speed activation range with an extra margin of 5 knots.
The generator mode icon will therefore stay white if the plane is within the speed activation range

@Maverickwoe
Copy link

Can you modify this with the additional text (in bold)
"When configured in the "Take Off" arming, the timer will start once FLEX or TOGA thrust is set for the first time and the plane moves."

@Maverickwoe
Copy link

Can you modify this with the additional text (in bold)
"TAKE OFF: The generator will wait until FLEX or TOGA thrust is set while speed is low on the ground to arm itself. It will trigger a set of failures only once until the plane entirely stops and another take off event occurs.

@Valastiri
Copy link
Member Author

Valastiri commented Sep 18, 2023

@Maverickwoe Hallo there!

Icons + descriptions to follow later as I only had time to put in the text-based changes for now.


Can you add in the section "Timed Failure Generator" Note : The timer is running when the generator mode icon is blue

Done - within "info" admonition


Can you add at the end of the section "Altitude Failure Generator" The failure generator can only arm itself when the plane is outside of the altitude activation range with an extra margin of 100 feet. The generator mode icon will therefore stay white if the plane is within the altitude activation range

Can you add at the end of the section "Speed Failure Generator" The failure generator can only arm itself when the plane is outside of the speed activation range with an extra margin of 5 knots. The generator mode icon will therefore stay white if the plane is within the speed activation range

Done - within "info" admonition


Can you modify this with the additional text (in bold) "When configured in the "Take Off" arming, the timer will start once FLEX or TOGA thrust is set for the first time and the plane moves."

Where exactly am I adding this information?


Can you modify this with the additional text (in bold) "TAKE OFF: The generator will wait until FLEX or TOGA thrust is set while speed is low on the ground to arm itself. It will trigger a set of failures only once until the plane entirely stops and another take off event occurs.

Done

@Maverickwoe
Copy link

Can you modify this with the additional text (in bold) "When configured in the "Take Off" arming, the timer will start once FLEX or TOGA thrust is set for the first time and the plane moves."

Where exactly am I adding this information?

this is a change in the TAKE OFF mode description in the section "Configuration Options"

@Valastiri Valastiri changed the title docs(failures): update page with generator + images feat(failures): update with generator + images + inline bootstrap icon config Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature guide repo Changes to Repo or Config Review Required PR Check Label waiting on a32nx PR PRs waiting for the corresponding a32nx repo PR to be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[META] Create failures pages
3 participants