Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add <meta> tags (Group 3) #952

Merged

Conversation

marcpicaud
Copy link
Contributor

Hey there!

Summary

This PR adds <meta> tags to the pages listed as "Group 3" in #791 .

I kept the descriptions under 150 chars, and aimed for good SEO and conciseness. Feedback welcome !

Location

For the pages listed as "Group 3" in flybywiresim#791
Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 17, 2024 7:17pm

@@ -1,3 +1,8 @@
---
title: A32NX Beginner Guide - Descent Planning and Descent
description: Learn how to plan and fly a descent from cruise altitude through STAR and Instrument Approach up to the final approach with the FlyByWire A32NX.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description seems a bit wordy but otherwise fine. Don't have a suggestion right as of this moment. Just a review consideration.

@Valastiri
Copy link
Member

If you feel like the comment doesn't require any changes feel free to ping me since everything else LGTM.

Thanks again!

@github-actions github-actions bot added the Review Required PR Check Label label Mar 24, 2024
@github-actions github-actions bot removed the Review Required PR Check Label label Apr 4, 2024
@github-actions github-actions bot merged commit 00c62df into flybywiresim:primary Apr 4, 2024
8 of 9 checks passed
@Valastiri
Copy link
Member

Hey @marcpicaud -- we noticed an issue with this that wasn't evident on local testing.

Our .pages setup for the beginners guide doesn't have actual defined titles and your meta implementation overwrote the navigation.

Would you mind re-opening the PR and we can fix that for you. Or alternatively it's strictly adding a defined title to the .pages navigation if you wish to handle that yourself. Apologies for the mixup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants