Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libchdr: add build option for using system library #1739

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

bsdcode
Copy link
Contributor

@bsdcode bsdcode commented Nov 13, 2024

The added build option USE_HOST_LIBCHDR allows to build with libchdr provided by the system. The option is disabled by default.

I have no experience with building for Android, Apple or the Switch, so I don't know if it's also necessary to exclude them from using the system library.

The added build option USE_HOST_LIBCHDR allows to build with libchdr provided by
the system. The option is disabled by default.
@flyinghead flyinghead merged commit d259a2e into flyinghead:master Nov 14, 2024
15 checks passed
@flyinghead
Copy link
Owner

Thanks!

@bsdcode bsdcode deleted the libchdr branch November 14, 2024 12:24
@abouvier
Copy link
Contributor

Why did you exclude libretro build? If USE_HOST_LIBCHDR is set, it should be enabled for every target.

@bsdcode
Copy link
Contributor Author

bsdcode commented Nov 27, 2024

I have little experience with libretro cores and how RetroArch handles this. There was no other reason other than inexperience on the libretro topic. Now on a second look I was probably wrong here, because chdr-static was always build previously.

@flyinghead
Copy link
Owner

Fixed by df78a78

@abouvier
Copy link
Contributor

By the way, libretro-common also contains a copy of libchdr headers in core/deps/libretro-common/include/libchdr.
They are searched for, and can hijack the system headers because of this line:

target_include_directories(${PROJECT_NAME} PRIVATE core/deps/libretro-common/include)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants