Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text may be painted on wrong page #16

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

gmottram
Copy link
Contributor

@gmottram gmottram commented Feb 1, 2012

If the content area of a line box overflows the line box itself, text may be painted on the previous page for the first line box of a page.

@pbrant
Copy link
Member

pbrant commented Jul 21, 2012

Hi Geoff --

I've merged fcba0a2, d3d0b48, and 735c1f0 (and applied it to the itext5 module). I can't put e8b1465 in the main repository as it breaks spec compliance (although I agree the behavior it addresses is a bug).

@pbrant pbrant closed this Jul 21, 2012
@gmottram
Copy link
Contributor Author

On 7/21/2012 5:46 PM, pbrant wrote:

Hi Geoff --

I've merged fcba0a2, d3d0b48, and 735c1f0 (and applied it to the itext5 module). I can't put e8b1465 in the main repository as it breaks spec compliance (although I agree the behavior it addresses is a bug).


Reply to this email directly or view it on GitHub:
#16 (comment)

Sorry Pete, I forgot what e8b1465 is. Which specification does it break?

Thanks for merging in those additions.

Geoff

@pbrant
Copy link
Member

pbrant commented Jul 22, 2012

The removal of the half-leading code (which essentially means that the
rendered glyphs will [probably] fit in their line box) [1]. It's a
reasonable thought, but it isn't the right. See
http://meyerweb.com/eric/css/inline-format.html for the gory details. I
think the right fix will be on the rendering side to not draw the text if
the line box doesn't overlap with the page being drawn.

Peter

[1]
gmottram@e8b1465

On Sun, Jul 22, 2012 at 1:30 AM, Geoff Mottram <
reply@reply.github.com

wrote:

On 7/21/2012 5:46 PM, pbrant wrote:

Hi Geoff --

I've merged fcba0a2, d3d0b48, and 735c1f0 (and applied it to the itext5
module). I can't put e8b1465 in the main repository as it breaks spec
compliance (although I agree the behavior it addresses is a bug).


Reply to this email directly or view it on GitHub:

#16 (comment)

Sorry Pete, I forgot what e8b1465 is. Which specification does it break?

Thanks for merging in those additions.

Geoff


Reply to this email directly or view it on GitHub:

#16 (comment)

@gmottram
Copy link
Contributor Author

Hi Peter,

Now I remember. It was the best fix I could come up with, not knowing the
system well enough to do it right. If you could put the bug on a list of
open issues, I would appreciate it. I'm glad you found the other
improvements useful.

Thanks for all of your hard work on this project.

Geoff

On 07/22/2012 04:39 AM, pbrant wrote:

The removal of the half-leading code (which essentially means that the
rendered glyphs will [probably] fit in their line box) [1]. It's a
reasonable thought, but it isn't the right. See
http://meyerweb.com/eric/css/inline-format.html for the gory details. I
think the right fix will be on the rendering side to not draw the text if
the line box doesn't overlap with the page being drawn.

Peter

[1]
gmottram@e8b1465

On Sun, Jul 22, 2012 at 1:30 AM, Geoff Mottram <
reply@reply.github.com

wrote:

On 7/21/2012 5:46 PM, pbrant wrote:

Hi Geoff --

I've merged fcba0a2, d3d0b48, and 735c1f0 (and applied it to the itext5
module). I can't put e8b1465 in the main repository as it breaks spec
compliance (although I agree the behavior it addresses is a bug).


Reply to this email directly or view it on GitHub:

#16 (comment)

Sorry Pete, I forgot what e8b1465 is. Which specification does it break?

Thanks for merging in those additions.

Geoff


Reply to this email directly or view it on GitHub:

#16 (comment)


Reply to this email directly or view it on GitHub:
#16 (comment)

@pbrant pbrant reopened this Jul 22, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants