Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gpiod: enable pullup/pulldown #341

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Conversation

chatziko
Copy link
Contributor

@chatziko chatziko commented Jan 7, 2024

This simple PR enables pullup/pulldown for gpiod, it's supported since python3-gpiod 1.5.2.

Note (independent from this PR)

The current code requires python3-gpiod <= 1.5.4, versions after 1.5.4 have completely changed the API. Hopefully, at least in my rasperry pi, pip seems to choose 1.5.4 instead of the latest versions. But it would be better to explicitly require python3-gpiod == 1.5.4.

@BenjiU
Copy link
Collaborator

BenjiU commented Feb 26, 2024

Hi @chatziko,

could you please fix this one lint message, than I'll merge this PR :-)
mqtt_io/modules/gpio/gpiod.py:23:0: R0902: Too many instance attributes (8/7) (too-many-instance-attributes)

Thank you!

@chatziko
Copy link
Contributor Author

Done. I left flags_map as an attribute, to be consistent with the rest of the code (direction_map, interrupt_edge_map, etc). And just added pylint: disable=too-many-instance-attributes which is already used in a few other places, so I guess it's acceptable.

@BenjiU BenjiU merged commit ec4c087 into flyte:develop Feb 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants