Add finalizer to avoid premature CRD Deletion (#5788)

Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
flyteorg · Oct 9, 2024 · d062824 · d062824
1 parent 604be4a
commit d062824
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/flyteadmin/pkg/workflowengine/impl/prepare_execution.go b/flyteadmin/pkg/workflowengine/impl/prepare_execution.go
@@ -129,6 +129,9 @@ func PrepareFlyteWorkflow(data interfaces.ExecutionData, flyteWorkflow *v1alpha1
  acceptAtWrapper := v1.NewTime(data.ExecutionParameters.AcceptedAt)
  flyteWorkflow.AcceptedAt = &acceptAtWrapper
 
+ // Add finalizer
+ flyteWorkflow.Finalizers = append(flyteWorkflow.Finalizers, "flyte-finalizer")
+
  // add permissions from auth and security context. Adding permissions from auth would be removed once all clients
  // have migrated over to security context
  addPermissions(data.ExecutionParameters.ExecutionConfig.SecurityContext,

diff --git a/flyteadmin/pkg/workflowengine/impl/prepare_execution_test.go b/flyteadmin/pkg/workflowengine/impl/prepare_execution_test.go
@@ -254,4 +254,5 @@ func TestPrepareFlyteWorkflow(t *testing.T) {
  OutputLocationPrefix: "s3://bucket/key",
  },
  })
+ assert.Equal(t, flyteWorkflow.Finalizers, []string{"flyte-finalizer"})
 }