Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch form fails without error when using unsupported required inputs #291

Closed
1 of 13 tasks
schottra opened this issue Apr 23, 2020 · 1 comment
Closed
1 of 13 tasks

Launch form fails without error when using unsupported required inputs #291

schottra opened this issue Apr 23, 2020 · 1 comment
Assignees
@schottra
Labels
bug Something isn't working ui Admin console user interface
Milestone
0.7.0

Comments

@schottra
Copy link
Contributor

schottra commented Apr 23, 2020 •
edited
Loading

Describe the bug
When using an input type that is unsupported in Flyte Console (such as schema), is required by the workflow, and also has no default value, clicking on Launch seems to have no effect and provides no feedback to the user.

Expected behavior
An error should be displayed about an input being required, or the user should otherwise be notified that it's not possible to launch this workflow because of the required/unsupported value.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. Browse to a workflow which uses an input type that is not supported by Flyte Console, such as Schema or Binary
  2. Click Launch Workflow
  3. Fill in any other required, supported values
  4. Click "Launch"
@schottra schottra added bug Something isn't working ui Admin console user interface untriaged This issues has not yet been looked at by the Maintainers labels Apr 23, 2020
@schottra schottra self-assigned this Apr 23, 2020
@schottra schottra changed the title [BUG] Launch form fails without error when using unsupported required inputs Launch form fails without error when using unsupported required inputs Jul 6, 2020
@schottra schottra assigned schottra and unassigned schottra Jul 6, 2020
@schottra schottra added this to the 0.7.0 milestone Jul 7, 2020
@schottra schottra mentioned this issue Jul 15, 2020
Merged
@schottra schottra removed the untriaged This issues has not yet been looked at by the Maintainers label Jul 15, 2020
@schottra
Copy link
Contributor Author

Fixed by flyteorg/flyteconsole#84. Available in flyteconsole v0.7.4

eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@pingsutw
The status of the AWS batch job should become failed once the retry l…
d5295d2 
…imit exceeded (flyteorg#291)

* Turn PhaseRetryableFailure into PhaseRetryLimitExceededFailure

Signed-off-by: Kevin Su <pingsutw@apache.org>

* nit

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update test

Signed-off-by: Kevin Su <pingsutw@apache.org>

* lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* wip

Signed-off-by: Kevin Su <pingsutw@apache.org>

* udpate

Signed-off-by: Kevin Su <pingsutw@apache.org>

* address comment

Signed-off-by: Kevin Su <pingsutw@apache.org>

* nit

Signed-off-by: Kevin Su <pingsutw@apache.org>

* fix tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* nit

Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@SandraGH5
Update dynamics.py (flyteorg#291)
106aff7
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@anrusina
chore: allow times timeline update, while execution in progress #patch (
dbdf247 
flyteorg#291)

* chore: allow times timeline update, while execution in progress
* chore: add dynamic timeleine scale
* chore: update eslint and coverage settings
* chore: fix scroll
* fix: ensure that leveling is part of node distinguish
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
@yindia
fix create project bug (flyteorg#291)
0deb501 
Signed-off-by: Yuvraj <code@evalsocket.dev>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
@pingsutw
The status of the AWS batch job should become failed once the retry l…
17b3010 
…imit exceeded (flyteorg#291)

* Turn PhaseRetryableFailure into PhaseRetryLimitExceededFailure

Signed-off-by: Kevin Su <pingsutw@apache.org>

* nit

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update test

Signed-off-by: Kevin Su <pingsutw@apache.org>

* lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update

Signed-off-by: Kevin Su <pingsutw@apache.org>

* update tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* lint

Signed-off-by: Kevin Su <pingsutw@apache.org>

* wip

Signed-off-by: Kevin Su <pingsutw@apache.org>

* udpate

Signed-off-by: Kevin Su <pingsutw@apache.org>

* address comment

Signed-off-by: Kevin Su <pingsutw@apache.org>

* nit

Signed-off-by: Kevin Su <pingsutw@apache.org>

* fix tests

Signed-off-by: Kevin Su <pingsutw@apache.org>

* nit

Signed-off-by: Kevin Su <pingsutw@apache.org>

Signed-off-by: Kevin Su <pingsutw@apache.org>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Apr 30, 2024
@yindia
fix create project bug (flyteorg#291)
6358243 
Signed-off-by: Yuvraj <code@evalsocket.dev>
austin362667 pushed a commit to austin362667/flyte that referenced this issue May 7, 2024
@yindia @austin362667
fix create project bug (flyteorg#291)
e512d9d 
Signed-off-by: Yuvraj <code@evalsocket.dev>
robert-ulbrich-mercedes-benz pushed a commit to robert-ulbrich-mercedes-benz/flyte that referenced this issue Jul 2, 2024
@yindia @robert-ulbrich-mercedes-benz
fix create project bug (flyteorg#291)
73a3a67 
Signed-off-by: Yuvraj <code@evalsocket.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schottra schottra

Labels
bug Something isn't working ui Admin console user interface
Projects
None yet
Milestone
0.7.0
Development

No branches or pull requests
1 participant
@schottra