Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Configuring ephemeral-storage request/limits for Flyte tasks #494

Closed
3 of 20 tasks
rstanevich opened this issue Sep 2, 2020 · 1 comment
Closed
3 of 20 tasks
Assignees
Labels
bug Something isn't working
Milestone

Comments

@rstanevich
Copy link
Contributor

rstanevich commented Sep 2, 2020

Describe the bug
A Python task has an option to define storage_request and storage_limit at the arguments: Source
But these values don't appear in the requests/limits parameters of k8s Pod.

Expected behavior
An option to specify ephemeral-storage requests/limits for the Pod running in Kubernetes.
https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#local-ephemeral-storage

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Steps to reproduce the behavior:

  1. Create a python task with argument storage_request:
@python_task(memory_request='2000M', cpu_request='500m', storage_request='1Gi')
    ...
  1. Run this in Flyte.
  2. We see that FlyteWorkflow CRD instance has these requests parameters in the tasks section:
...
tasks:
  '<< task unique name >> ':
    container:
      resources:
        requests:
          - name: CPU
            value: 500m
          - name: MEMORY
            value: 2000M
         - name: STORAGE
            value: 1Gi
...
  1. But nodes section in the FlyteWorkflow instance and created Pod specification don't have ephemeral-storage requests:
resources:
    requests:
        cpu: 500m
        memory: 2000M

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
Discussed with @kumare3 in the Slack. He suggested to file an issue for storage support.
The use case example: a task in which we expect a huge file with geographic data which is very problematic to split.

@rstanevich rstanevich added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Sep 2, 2020
@kumare3
Copy link
Contributor

kumare3 commented Sep 2, 2020

Thank you @rstanevich, we will track it for the next release

@kumare3 kumare3 self-assigned this Sep 2, 2020
@kumare3 kumare3 removed their assignment Sep 28, 2020
@kumare3 kumare3 added this to the 0.9.0 milestone Sep 28, 2020
@EngHabu EngHabu modified the milestones: 0.9.0, 0.10.0 Nov 4, 2020
@EngHabu EngHabu removed this from the 0.10.0 milestone Jan 11, 2021
@katrogan katrogan self-assigned this Aug 3, 2021
@katrogan katrogan added this to the 0.17.0 milestone Aug 3, 2021
@katrogan katrogan removed the untriaged This issues has not yet been looked at by the Maintainers label Aug 3, 2021
@katrogan katrogan closed this as completed Aug 6, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 6, 2022
* Add configurable UTC timezone option for scheduler

Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>

* Add comments for default behavior

Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>

Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Dec 20, 2022
* fix: support mapped tasks #none

Signed-off-by: James <james@union.ai>

* fix: fix comments #none

Signed-off-by: James <james@union.ai>

* fix: fix unit test #none

Signed-off-by: James <james@union.ai>

* fix: add string constants #none

Signed-off-by: James <james@union.ai>

* fix: added test for mapInputHelper #none

Signed-off-by: James <james@union.ai>

* fix: fix test for utils.test.ts #none

Signed-off-by: James <james@union.ai>

* chore: trigger snyk re-run

* fix: multiple keys for mapped types; #none

Signed-off-by: James <james@union.ai>

* chore: storybook item (flyteorg#530)

Signed-off-by: Nastya Rusina <nastya@union.ai>

* fix: fix validation for duplicate and fix focus issue

Signed-off-by: James <james@union.ai>

* chore: provide previous run values on relaunch

Signed-off-by: Nastya Rusina <nastya@union.ai>

Co-authored-by: Nastya <55718143+anrusina@users.noreply.github.com>
Co-authored-by: Nastya Rusina <nastya@union.ai>
eapolinario pushed a commit to eapolinario/flyte that referenced this issue Aug 21, 2023
* Add configurable UTC timezone option for scheduler

Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>

* Add comments for default behavior

Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>

Signed-off-by: pmahindrakar-oss <prafulla.mahindrakar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants