Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Flytecookbook for v0.16.0b1 has bugs #687

Closed
2 of 20 tasks
kumare3 opened this issue Jan 31, 2021 · 3 comments
Closed
2 of 20 tasks

[BUG] Flytecookbook for v0.16.0b1 has bugs #687

kumare3 opened this issue Jan 31, 2021 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@kumare3
Copy link
Contributor

kumare3 commented Jan 31, 2021

Describe the bug
Unable to register workflows using latest flytecookbook instructions.

Bugs

  1. make register command does not have --insecure option for local deployment
  2. Bug in registering kfpytorch example
grpc._channel._InactiveRpcError: <_InactiveRpcError of RPC that terminated with:
	status = StatusCode.INVALID_ARGUMENT
	details = "Type MEMORY for [resource_type:TASK project:"flytetester" domain:"development" name:"recipes.plugins.kfpytorch.pytorch_mnist.mnist_pytorch_job" version:"1dd37fc240178837bab476d429e1ee09232a6c05" ] cannot set limit > platform limit"
  1. Make register uses
    --kubernetes-service-account demo
    This fails at runtime with
[1/1] currentAttempt done. Last Error: USER::pods "oze826a6ot-n0-0" is forbidden: error looking up service account flytetester-development/demo: serviceaccount "demo" not found
  1. Then the image itself is not pushed
[1/1] currentAttempt done. Last Error: USER::containers with unready status: [wj6a59yv8j-n0-0]|Back-off pulling image "flytecookbook:1dd37fc240178837bab476d429e1ee09232a6c05"
  1. Also Case-studies docker image is not pushed
  File "/root/recipes/case_studies/pima_diabetes/diabetes.py", line 10, in <module>
    import joblib
ModuleNotFoundError: No module named 'joblib'
  1. Mergesort fails, because flyteadmin new version is not deployed
	Error 7: Code: ParameterNotBound, Node Id: fxw4uysi, Description: Parameter not bound [numbers].
	Error 8: Code: ParameterNotBound, Node Id: fxw4uysi, Description: Parameter not bound [numbers_count].
	Error 9: Code: UnreachableNodes, Node Id: start-node, Description: The Workflow contain unreachable nodes [fxw4uysi,fxk4upea,fxo4usiy].

Expected behavior
Examples should be registered in one go.

Flyte component

  • Overall
  • Flyte Setup and Installation scripts
  • Flyte Documentation
  • Flyte communication (slack/email etc)
  • FlytePropeller
  • FlyteIDL (Flyte specification language)
  • Flytekit (Python SDK)
  • FlyteAdmin (Control Plane service)
  • FlytePlugins
  • DataCatalog
  • FlyteStdlib (common libraries)
  • FlyteConsole (UI)
  • Other

To Reproduce
Start local sandbox cluster
run make serialize and make register as follows
OUTPUT_DATA_PREFIX=s3://my-s3-bucket/raw_data FLYTE_HOST=localhost:80 make register

Environment
Flyte component

  • Sandbox (local or on one machine)
  • Cloud hosted
    • AWS
    • GCP
    • Azure
  • Baremetal
  • Other

Additional context
NA

@kumare3 kumare3 added bug Something isn't working untriaged This issues has not yet been looked at by the Maintainers labels Jan 31, 2021
@katrogan katrogan self-assigned this Feb 4, 2021
@katrogan katrogan removed their assignment Feb 4, 2021
@katrogan
Copy link
Contributor

katrogan commented Feb 4, 2021

@kumare3 do you mind using your blazing fast connection to push the missing images?

@katrogan katrogan closed this as completed Feb 4, 2021
@katrogan katrogan reopened this Feb 4, 2021
@katrogan katrogan removed the untriaged This issues has not yet been looked at by the Maintainers label Feb 9, 2021
@kumare3
Copy link
Contributor Author

kumare3 commented Feb 16, 2021

@EngHabu can you close this once you push out your changes for flytesnacks

@kumare3 kumare3 added this to the 0.11.0 milestone Feb 28, 2021
@kumare3
Copy link
Contributor Author

kumare3 commented Feb 28, 2021

These issues have been resolved. My tests worked

@kumare3 kumare3 closed this as completed Feb 28, 2021
palchicz pushed a commit to palchicz/flyte that referenced this issue Dec 23, 2021
* Run 3.9 in CI

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Also run 3.9 in plugins tests.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Fix tests

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Account for the different exception type raised in case of wrong types

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Exclude spark2

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Failed to load json_data to dataclass (flyteorg#684)

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove sync singledispatch, add option for top-level only sync (flyteorg#681)

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Failed to transform path string to Literal (flyteorg#689)

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Don't node sync on remote wait (flyteorg#690)

* no node sync

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* add param to wait

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Fix plugin regressions (flyteorg#688)

* fix pandera regression

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* install plugin with pip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* fix pandera plugin tests

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* add spark flytekit plugin to papermill test_requires

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* add sqlalchemy to great expectations plugin

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* wip

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* plugins plugins plugins!

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* lint

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>

* Exclude does not understand lists

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Invert python version check

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Invert python version check for real this time

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Enable 3.10 just for kicks

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Add quotes around python versions

Yes, this is needed, please see https://dev.to/hugovk/the-python-3-1-problem-85g.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Add quotes around python versions"

This reverts commit 4d619d5c9e829aa1fdc18d2d87e1dbe4dbf42372.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Enable 3.10 just for kicks"

This reverts commit bd6d69462cb722afc5e2eb09ce77e35da512d288.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* wip - restricted types

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* wip - restricted types

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Comment use of restricted types in get_transformer

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Publish 3.9 image

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Add python 3.9 to the list of supported languages

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Comment RestrictedTypeTransformer and add one test case.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Review feedback

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Comment RestrictedTypeTransformer

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Handle the TypeError

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove breakpoint

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Co-authored-by: Niels Bantilan <niels.bantilan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants