Add flyteexamples project to sandbox deploy #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
approved these changes
Feb 5, 2020
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 6, 2022
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 6, 2022
…D and OAuth2 configs, OAuth2 Metadata over gRPC #minor (flyteorg#168) * wip: OAuth2 Support Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * wip Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * wip Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * tighten security of generated tokens Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Support storing form post values in auth code JWT Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * save secrets to k8s secrets Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Expose metadata endpoints over gRPC Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * trim OpenID Connect config further Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Selectively authenticate gRPC endpoints Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Support external oauth2 server and Okta Config Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * update config Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix nil secrets data map Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fixed the pointer overwrite issue in oauthServer metadata (flyteorg#183) Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Co-authored-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Simplify config further and move auth package up Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix clusterresource Project and domain(flyteorg#167) * Fix clusterresource Project Signed-off-by: Anand Swaminathan <aswaminathan@lyft.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Bump flyteidl version to pick up auth role field number fix (flyteorg#169) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add option to use project name as namespace for the task pods (flyteorg#166) * Add option to use project name as namespace for the task pods Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com> * rename Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * GetExecution performance improvements (flyteorg#171) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add exists check for workflow & node executions (flyteorg#172) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Remove legacy fetch for workflow execution inputs (flyteorg#173) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Added release workflow (flyteorg#170) Signed-off-by: yuvraj <evalsocket@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update Flyteidl version (flyteorg#175) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Added version in flyteadmin (flyteorg#154) * wip: added version pkg Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: resolve conflict Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: added version in rpc Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: small fixes Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: Added panic cache in get version service Signed-off-by: yuvraj <evalsocket@gmail.com> * Added flytestdlib for version package Signed-off-by: yuvraj <evalsocket@gmail.com> * Added version service test Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <evalsocket@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Propagate nesting and principal for child executions (flyteorg#177) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Write workflow and node execution events asynchronously (flyteorg#174) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add sensible flyteadmin config defaults (flyteorg#179) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * further cleanup Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Only register authserver when auth is enabled Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update to latest flyteidl and separate auth interfaces Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * dead code Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * PR Comments Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * merge master Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Move to authorizedUris Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update to released flyteidl Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix response expiry and add unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update go mod Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * fix unit tests that broke because of identity changes Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Co-authored-by: pmahindrakar-oss <77798312+pmahindrakar-oss@users.noreply.github.com> Co-authored-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Co-authored-by: Anand Swaminathan <aswaminathan@lyft.com> Co-authored-by: Katrina Rogan <katrina@nuclyde.io> Co-authored-by: Jeev B <jeevb@users.noreply.github.com> Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com> Co-authored-by: Flyte Bot <admin@flyte.org>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
…flyteorg#168) `flytectl get task/workflow/launchplan -o table` panics if resource has no expected output. We encountered `FormatVariableDescriptions at pkg/printer/printer.go:173` to panic when using the get commands on a resource without expected output. This happened with both explicit table output as well as default. Replicated on lastest master, workflow demo-1.no-output has no expected output: ``` $ go run ./main.go get launchplans -p demo-1 -d production --latest demo-1.no-output panic: assignment to entry in nil map goroutine 1 [running]: github.com/flyteorg/flytectl/pkg/printer.FormatVariableDescriptions(0x0) /workspace/flyteorg/flytectl/pkg/printer/printer.go:202 +0x307 github.com/flyteorg/flytectl/cmd/get.LaunchplanToTableProtoMessages({0xc000a30938, 0x1, 0x7ffeefbff977}) /workspace/flyteorg/flytectl/cmd/get/launch_plan.go:136 +0xee github.com/flyteorg/flytectl/cmd/get.getLaunchPlanFunc({0x2dfbf98, 0xc0000580b8}, {0xc0002fb8c0, 0x1, 0x11519b4}, {{0x2e55850, 0xc000a30120}, {0x2e472c0, 0xc0009a3110}, {0x2ddff60, ...}, ...}) /workspace/flyteorg/flytectl/cmd/get/launch_plan.go:158 +0x307 github.com/flyteorg/flytectl/cmd/core.generateCommandFunc.func1(0xc000481680, {0xc0002fb8c0, 0x1, 0x6}) /workspace/flyteorg/flytectl/cmd/core/cmd.go:69 +0x47d github.com/spf13/cobra.(*Command).execute(0xc000481680, {0xc0002fb860, 0x6, 0x6}) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:852 +0x60e github.com/spf13/cobra.(*Command).ExecuteC(0xc000480000) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:960 +0x3ad github.com/spf13/cobra.(*Command).Execute(...) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:897 github.com/flyteorg/flytectl/cmd.ExecuteCmd() /workspace/flyteorg/flytectl/cmd/root.go:135 +0x1e main.main() /workspace/flyteorg/flytectl/main.go:12 +0x1d exit status 2 ``` Simple fix: nil checks exists for container but not on the map itself prior to calling, and nil input causes the panic. Added nil check on map parameter prior to calling in all places found. Signed-off-by: Viktor Gerdin <viktorg@spotify.com>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 9, 2023
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
…D and OAuth2 configs, OAuth2 Metadata over gRPC #minor (flyteorg#168) * wip: OAuth2 Support Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * wip Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * wip Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * tighten security of generated tokens Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Support storing form post values in auth code JWT Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * save secrets to k8s secrets Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Expose metadata endpoints over gRPC Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * trim OpenID Connect config further Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Selectively authenticate gRPC endpoints Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Support external oauth2 server and Okta Config Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * update config Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix nil secrets data map Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fixed the pointer overwrite issue in oauthServer metadata (flyteorg#183) Signed-off-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Co-authored-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Simplify config further and move auth package up Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix clusterresource Project and domain(flyteorg#167) * Fix clusterresource Project Signed-off-by: Anand Swaminathan <aswaminathan@lyft.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Bump flyteidl version to pick up auth role field number fix (flyteorg#169) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add option to use project name as namespace for the task pods (flyteorg#166) * Add option to use project name as namespace for the task pods Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com> * rename Signed-off-by: Jeev B <jeev.balakrishnan@freenome.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * GetExecution performance improvements (flyteorg#171) Signed-off-by: Katrina Rogan <katroganGH@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add exists check for workflow & node executions (flyteorg#172) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Remove legacy fetch for workflow execution inputs (flyteorg#173) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Added release workflow (flyteorg#170) Signed-off-by: yuvraj <evalsocket@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update Flyteidl version (flyteorg#175) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Added version in flyteadmin (flyteorg#154) * wip: added version pkg Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: resolve conflict Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: added version in rpc Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: small fixes Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: Added panic cache in get version service Signed-off-by: yuvraj <evalsocket@gmail.com> * Added flytestdlib for version package Signed-off-by: yuvraj <evalsocket@gmail.com> * Added version service test Signed-off-by: yuvraj <evalsocket@gmail.com> * wip: added ldflags in goreleaser Signed-off-by: yuvraj <evalsocket@gmail.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Propagate nesting and principal for child executions (flyteorg#177) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Write workflow and node execution events asynchronously (flyteorg#174) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Add sensible flyteadmin config defaults (flyteorg#179) Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Lint Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * further cleanup Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Only register authserver when auth is enabled Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update to latest flyteidl and separate auth interfaces Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * dead code Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * PR Comments Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * merge master Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Move to authorizedUris Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update to released flyteidl Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix response expiry and add unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update go mod Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * fix unit tests that broke because of identity changes Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Co-authored-by: pmahindrakar-oss <77798312+pmahindrakar-oss@users.noreply.github.com> Co-authored-by: Prafulla Mahindrakar <prafulla.mahindrakar@gmail.com> Co-authored-by: Anand Swaminathan <aswaminathan@lyft.com> Co-authored-by: Katrina Rogan <katrina@nuclyde.io> Co-authored-by: Jeev B <jeevb@users.noreply.github.com> Co-authored-by: Yuvraj <10830562+evalsocket@users.noreply.github.com> Co-authored-by: Flyte Bot <admin@flyte.org>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Apr 30, 2024
…flyteorg#168) `flytectl get task/workflow/launchplan -o table` panics if resource has no expected output. We encountered `FormatVariableDescriptions at pkg/printer/printer.go:173` to panic when using the get commands on a resource without expected output. This happened with both explicit table output as well as default. Replicated on lastest master, workflow demo-1.no-output has no expected output: ``` $ go run ./main.go get launchplans -p demo-1 -d production --latest demo-1.no-output panic: assignment to entry in nil map goroutine 1 [running]: github.com/flyteorg/flytectl/pkg/printer.FormatVariableDescriptions(0x0) /workspace/flyteorg/flytectl/pkg/printer/printer.go:202 +0x307 github.com/flyteorg/flytectl/cmd/get.LaunchplanToTableProtoMessages({0xc000a30938, 0x1, 0x7ffeefbff977}) /workspace/flyteorg/flytectl/cmd/get/launch_plan.go:136 +0xee github.com/flyteorg/flytectl/cmd/get.getLaunchPlanFunc({0x2dfbf98, 0xc0000580b8}, {0xc0002fb8c0, 0x1, 0x11519b4}, {{0x2e55850, 0xc000a30120}, {0x2e472c0, 0xc0009a3110}, {0x2ddff60, ...}, ...}) /workspace/flyteorg/flytectl/cmd/get/launch_plan.go:158 +0x307 github.com/flyteorg/flytectl/cmd/core.generateCommandFunc.func1(0xc000481680, {0xc0002fb8c0, 0x1, 0x6}) /workspace/flyteorg/flytectl/cmd/core/cmd.go:69 +0x47d github.com/spf13/cobra.(*Command).execute(0xc000481680, {0xc0002fb860, 0x6, 0x6}) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:852 +0x60e github.com/spf13/cobra.(*Command).ExecuteC(0xc000480000) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:960 +0x3ad github.com/spf13/cobra.(*Command).Execute(...) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:897 github.com/flyteorg/flytectl/cmd.ExecuteCmd() /workspace/flyteorg/flytectl/cmd/root.go:135 +0x1e main.main() /workspace/flyteorg/flytectl/main.go:12 +0x1d exit status 2 ``` Simple fix: nil checks exists for container but not on the map itself prior to calling, and nil input causes the panic. Added nil check on map parameter prior to calling in all places found. Signed-off-by: Viktor Gerdin <viktorg@spotify.com>
austin362667
pushed a commit
to austin362667/flyte
that referenced
this pull request
May 7, 2024
…flyteorg#168) `flytectl get task/workflow/launchplan -o table` panics if resource has no expected output. We encountered `FormatVariableDescriptions at pkg/printer/printer.go:173` to panic when using the get commands on a resource without expected output. This happened with both explicit table output as well as default. Replicated on lastest master, workflow demo-1.no-output has no expected output: ``` $ go run ./main.go get launchplans -p demo-1 -d production --latest demo-1.no-output panic: assignment to entry in nil map goroutine 1 [running]: github.com/flyteorg/flytectl/pkg/printer.FormatVariableDescriptions(0x0) /workspace/flyteorg/flytectl/pkg/printer/printer.go:202 +0x307 github.com/flyteorg/flytectl/cmd/get.LaunchplanToTableProtoMessages({0xc000a30938, 0x1, 0x7ffeefbff977}) /workspace/flyteorg/flytectl/cmd/get/launch_plan.go:136 +0xee github.com/flyteorg/flytectl/cmd/get.getLaunchPlanFunc({0x2dfbf98, 0xc0000580b8}, {0xc0002fb8c0, 0x1, 0x11519b4}, {{0x2e55850, 0xc000a30120}, {0x2e472c0, 0xc0009a3110}, {0x2ddff60, ...}, ...}) /workspace/flyteorg/flytectl/cmd/get/launch_plan.go:158 +0x307 github.com/flyteorg/flytectl/cmd/core.generateCommandFunc.func1(0xc000481680, {0xc0002fb8c0, 0x1, 0x6}) /workspace/flyteorg/flytectl/cmd/core/cmd.go:69 +0x47d github.com/spf13/cobra.(*Command).execute(0xc000481680, {0xc0002fb860, 0x6, 0x6}) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:852 +0x60e github.com/spf13/cobra.(*Command).ExecuteC(0xc000480000) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:960 +0x3ad github.com/spf13/cobra.(*Command).Execute(...) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:897 github.com/flyteorg/flytectl/cmd.ExecuteCmd() /workspace/flyteorg/flytectl/cmd/root.go:135 +0x1e main.main() /workspace/flyteorg/flytectl/main.go:12 +0x1d exit status 2 ``` Simple fix: nil checks exists for container but not on the map itself prior to calling, and nil input causes the panic. Added nil check on map parameter prior to calling in all places found. Signed-off-by: Viktor Gerdin <viktorg@spotify.com>
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
…flyteorg#168) `flytectl get task/workflow/launchplan -o table` panics if resource has no expected output. We encountered `FormatVariableDescriptions at pkg/printer/printer.go:173` to panic when using the get commands on a resource without expected output. This happened with both explicit table output as well as default. Replicated on lastest master, workflow demo-1.no-output has no expected output: ``` $ go run ./main.go get launchplans -p demo-1 -d production --latest demo-1.no-output panic: assignment to entry in nil map goroutine 1 [running]: github.com/flyteorg/flytectl/pkg/printer.FormatVariableDescriptions(0x0) /workspace/flyteorg/flytectl/pkg/printer/printer.go:202 +0x307 github.com/flyteorg/flytectl/cmd/get.LaunchplanToTableProtoMessages({0xc000a30938, 0x1, 0x7ffeefbff977}) /workspace/flyteorg/flytectl/cmd/get/launch_plan.go:136 +0xee github.com/flyteorg/flytectl/cmd/get.getLaunchPlanFunc({0x2dfbf98, 0xc0000580b8}, {0xc0002fb8c0, 0x1, 0x11519b4}, {{0x2e55850, 0xc000a30120}, {0x2e472c0, 0xc0009a3110}, {0x2ddff60, ...}, ...}) /workspace/flyteorg/flytectl/cmd/get/launch_plan.go:158 +0x307 github.com/flyteorg/flytectl/cmd/core.generateCommandFunc.func1(0xc000481680, {0xc0002fb8c0, 0x1, 0x6}) /workspace/flyteorg/flytectl/cmd/core/cmd.go:69 +0x47d github.com/spf13/cobra.(*Command).execute(0xc000481680, {0xc0002fb860, 0x6, 0x6}) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:852 +0x60e github.com/spf13/cobra.(*Command).ExecuteC(0xc000480000) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:960 +0x3ad github.com/spf13/cobra.(*Command).Execute(...) /workspace/go/pkg/mod/github.com/spf13/cobra@v1.1.3/command.go:897 github.com/flyteorg/flytectl/cmd.ExecuteCmd() /workspace/flyteorg/flytectl/cmd/root.go:135 +0x1e main.main() /workspace/flyteorg/flytectl/main.go:12 +0x1d exit status 2 ``` Simple fix: nil checks exists for container but not on the map itself prior to calling, and nil input causes the panic. Added nil check on map parameter prior to calling in all places found. Signed-off-by: Viktor Gerdin <viktorg@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.