Adding a base EKS deployment and overlay #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EngHabu
approved these changes
Apr 27, 2020
|
Mind adding an issue or filling in more information (maybe copying from the doc you wrote) about what is included... |
23 tasks
|
Done - #299 |
8 tasks
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 6, 2022
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
…flyteorg#298) Signed-off-by: Sean Lin <sean@union.ai>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Dec 20, 2022
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 9, 2023
Signed-off-by: Katrina Rogan <katroganGH@gmail.com>
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Aug 21, 2023
eapolinario
pushed a commit
to eapolinario/flyte
that referenced
this pull request
Apr 30, 2024
austin362667
pushed a commit
to austin362667/flyte
that referenced
this pull request
May 7, 2024
robert-ulbrich-mercedes-benz
pushed a commit
to robert-ulbrich-mercedes-benz/flyte
that referenced
this pull request
Jul 2, 2024
troychiu
pushed a commit
that referenced
this pull request
Jul 8, 2024
## Overview Currently, there is no way to set fasttask worker args beyond those exposed from the `ActorEnvironment` (ex. `parallelism`, `backlog_length`, etc). This means that many configuration options ([examples](https://github.com/unionai/flyte/blob/daniel%2Fexo-134-allow-propeller-to-inject-fasttask-worker-cli-args/fasttask/worker/src/main.rs#L45-L50)) are not exposed and are therefore restricted to the default values. This can be problematic in scenarios where task status reporting results in timeouts. This PR exposes worker args using an `additional-worker-args` configuration option through the fasttask plugin config to support all existing and future arguments. ## Test Plan This was tested locally. ## Rollout Plan (if applicable) As fasttask is an alpha / beta feature currently, and updates in this codebase only affect the fasttask execution path there should be minimal risks in immediate rollout. ## Upstream Changes Should this change be upstreamed to OSS (flyteorg/flyte)? If so, please check this box for auditing. Note, this is the responsibility of each developer. See [this guide](https://unionai.atlassian.net/wiki/spaces/ENG/pages/447610883/Flyte+-+Union+Cloud+Development+Runbook/#When-are-versions-updated%3F). - [ ] To be upstreamed ## Issue https://linear.app/unionai/issue/EXO-134/allow-propeller-to-inject-fasttask-worker-cli-args ## Checklist * [ ] Added tests * [ ] Ran a deploy dry run and shared the terraform plan * [ ] Added logging and metrics * [ ] Updated [dashboards](https://unionai.grafana.net/dashboards) and [alerts](https://unionai.grafana.net/alerting/list) * [ ] Updated documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's still some work to be done. Will keep iterating on this and refactoring some stuff in my spare time.
Remaining work detailed in #299