add cache evicted status #4705
Merged
add cache evicted status #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
dosubot
bot
added
size:L
pingsutw
approved these changes
Jan 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4705 +/- ##
==========================================
- Coverage 58.15% 58.12% -0.03%
==========================================
Files 626 626
Lines 53786 53786
==========================================
- Hits 31277 31265 -12
- Misses 20001 20013 +12
Partials 2508 2508
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
katrogan
pushed a commit
that referenced
this pull request
Jan 12, 2024
Signed-off-by: Paul Dittamo <pvdittamo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#2867
Why are the changes needed?
Need to add a new cache status as part of this PR. Returning a new cache status will break console so I figured updating CacheStatus idl -> updating console -> adding in task eviction endpoint made sense.
What changes were proposed in this pull request?
Add "CACHE_EVICTED" CacheStatus
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link