Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a ExecutionClusterLabel when triggering a Launchplan/Workflow/Task #4998

Merged
merged 12 commits into from
Mar 25, 2024

Merge branch 'flyteorg:master' into execution_label_in_cluster

72d52ca
Select commit
Loading
Failed to load commit list.
Merged

Allow setting a ExecutionClusterLabel when triggering a Launchplan/Workflow/Task #4998

Merge branch 'flyteorg:master' into execution_label_in_cluster
72d52ca
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 25, 2024 in 0s

59.00% (+0.02%) compared to feb4777

View this Pull Request on Codecov

59.00% (+0.02%) compared to feb4777

Details

Codecov Report

Attention: Patch coverage is 89.83051% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 59.00%. Comparing base (feb4777) to head (72d52ca).

Files Patch % Lines
...g/executioncluster/impl/random_cluster_selector.go 85.00% 2 Missing and 1 partial ⚠️
flyteadmin/pkg/manager/impl/execution_manager.go 90.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4998      +/-   ##
==========================================
+ Coverage   58.98%   59.00%   +0.02%     
==========================================
  Files         645      645              
  Lines       55648    55670      +22     
==========================================
+ Hits        32824    32850      +26     
+ Misses      20229    20224       -5     
- Partials     2595     2596       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.