Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update agent development documentation #5130

Merged
merged 15 commits into from
Apr 1, 2024
Merged

Conversation

pingsutw
Copy link
Member

@pingsutw pingsutw commented Mar 28, 2024

What changes were proposed in this pull request?

  • Update the existing agent example
  • Add a sensor example
  • Add a screenshot to show how to run BigQuery and Databricks tasks on your local machine

doc links:

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Mar 28, 2024
Signed-off-by: Kevin Su <pingsutw@gmail.com>
@dosubot dosubot bot added the documentation Improvements or additions to documentation label Mar 28, 2024
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.02%. Comparing base (c81133b) to head (c85631d).
Report is 21 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5130      +/-   ##
==========================================
- Coverage   59.03%   59.02%   -0.01%     
==========================================
  Files         645      645              
  Lines       55726    55726              
==========================================
- Hits        32896    32895       -1     
- Misses      20233    20234       +1     
  Partials     2597     2597              
Flag Coverage Δ
unittests 59.02% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kevin Su <pingsutw@gmail.com>
Copy link
Contributor

@neverett neverett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some suggestions, thanks for updating these docs!

docs/flyte_agents/developing_agents.md Outdated Show resolved Hide resolved
docs/flyte_agents/developing_agents.md Outdated Show resolved Hide resolved
docs/flyte_agents/developing_agents.md Outdated Show resolved Hide resolved
docs/flyte_agents/developing_agents.md Outdated Show resolved Hide resolved
docs/flyte_agents/developing_agents.md Outdated Show resolved Hide resolved
docs/flyte_agents/developing_agents.md Outdated Show resolved Hide resolved
docs/flyte_agents/developing_agents.md Outdated Show resolved Hide resolved
docs/flyte_agents/developing_agents.md Outdated Show resolved Hide resolved
docs/flyte_agents/developing_agents.md Outdated Show resolved Hide resolved
docs/flyte_agents/developing_agents.md Outdated Show resolved Hide resolved
pingsutw and others added 12 commits March 28, 2024 11:30
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
Co-authored-by: Nikki Everett <neverett@users.noreply.github.com>
Signed-off-by: Kevin Su <pingsutw@gmail.com>
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Apr 1, 2024
@neverett neverett merged commit b2d0d85 into master Apr 1, 2024
47 of 48 checks passed
@neverett neverett deleted the update-agent-doc branch April 1, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants