fix(webapi): Ensure cache deletion on abort workflow #5235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:S
EngHabu
reviewed
Apr 16, 2024
Comment on lines
102
to
108
| cacheItemID := tCtx.TaskExecutionMetadata().GetTaskExecutionID().GetGeneratedName() | ||
| err := c.cache.DeleteDelayed(cacheItemID) | ||
| if err != nil { | ||
| logger.Errorf(ctx, "Failed to delete resource [%v] from cache. Error: %v", cacheItemID, err) | ||
| return err | ||
| } | ||
|
|
There was a problem hiding this comment.
Should we do this in Finalize? so that it happens all the time
Signed-off-by: Kevin Su <pingsutw@apache.org>
EngHabu
previously approved these changes
Apr 22, 2024
EngHabu
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Propeller keeps sending the requests to agents because propeller didn't remove the item from the async cache when users aborted the workflow.
What changes were proposed in this pull request?
Delete the item from the cache on abort.
How was this patch tested?
local sandbox
Setup process
remote cluster
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA