added configuration for arraynode default parallelism behavior #5268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
pvditt
reviewed
Apr 23, 2024
pvditt
reviewed
Apr 23, 2024
pvditt
previously approved these changes
Apr 23, 2024
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
pvditt
previously approved these changes
Apr 23, 2024
Signed-off-by: Daniel Rammer <daniel@union.ai>
pvditt
approved these changes
Apr 23, 2024
pmahindrakar-oss
pushed a commit
that referenced
this pull request
May 1, 2024
* Feature/array node workflow parallelism (#5062) * update arraynode proto parallelism field to varint compatible int64 Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * have array nodes utilize workflow parallelism Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * return if available parallelism is 0 Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * unit test Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * enable parallelism to be set to nil for array node (#5214) * enable parallelism to be set to nil for array node Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * unit test Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> * added configuration for arraynode default parallelism behavior (#5268) * added configuration for arraynode default parallelism behavior Signed-off-by: Daniel Rammer <daniel@union.ai> * added unit tests and fixed linter Signed-off-by: Daniel Rammer <daniel@union.ai> * cleanup / docs Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed ytpo Signed-off-by: Daniel Rammer <daniel@union.ai> * docs update Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed unit tests Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Paul Dittamo <pvdittamo@gmail.com> Signed-off-by: Daniel Rammer <daniel@union.ai> Co-authored-by: Paul Dittamo <37558497+pvditt@users.noreply.github.com>
austin362667
pushed a commit
to austin362667/flyte
that referenced
this pull request
May 7, 2024
…org#5268) * added configuration for arraynode default parallelism behavior Signed-off-by: Daniel Rammer <daniel@union.ai> * added unit tests and fixed linter Signed-off-by: Daniel Rammer <daniel@union.ai> * cleanup / docs Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed ytpo Signed-off-by: Daniel Rammer <daniel@union.ai> * docs update Signed-off-by: Daniel Rammer <daniel@union.ai> * fixed unit tests Signed-off-by: Daniel Rammer <daniel@union.ai> --------- Signed-off-by: Daniel Rammer <daniel@union.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
NA
Why are the changes needed?
Defaulting to use the workflow parallleism in ArrayNode rather than unlimited may confuse some users and result in unexpected behavior.
What changes were proposed in this pull request?
This PR introduces ArrayNode default parallelism configuration, with three options:
unlimited: works as the legacy maptask parallelism where all subNodes are evaluatedworkflow: applies the parent workflow parallelism to ArrayNode subNode evaluationshybrid: the previous changes allowed differentiation withing flytekit, wherenil/Noneparallelism indicates using the parent workflow and0indicates using unlimited.How was this patch tested?
Extensive unit testing and deployed locally in multiple scenarios / configurations.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
#5214
flyteorg/flytekit#2268
Docs link
NA