Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Bubbletea list CLI for command selecting (get) #5540

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

zychen5186
Copy link
Contributor

@zychen5186 zychen5186 commented Jul 5, 2024

Tracking issue

Related to #4440

Why are the changes needed?

  1. Enhanced User Experience: Bubble Tea offers a more interactive and visually appealing interface. This enhances the overall user experience.
  2. Increased Accessibility: With Bubble Tea, we can create CLIs that are easier to navigate, especially for users who might not be familiar with command line operations. This accessibility broadens our tool's user base.

What changes were proposed in this pull request?

User can select the command they want to use through the CLI by typing

./bin/flytectl get -i

!!!Only get method is supported in this PR!!!
Uses GetDomain and ListProjects API to get project and domain if needed.

How was this patch tested?

This feature will only be triggered when -i flag is specified

Case tested:

./bin/flytectl -i (will not trigger bubbletea)
./bin/flytectl get -i 
./bin/flytectl get execution -p my-project  -i 
./bin/flytectl get execution -d development -i 
./bin/flytectl get execution -p my-project -d development -i 

Setup process

In flytectl directory run

make compile

Screenshots

Jul-09-2024 23-38-37

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#5310
#5357

Docs link

zychen5186 added 12 commits July 4, 2024 19:56
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Signed-off-by: zychen5186 <brianchen5197@gmail.com>
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.98%. Comparing base (b63ce0e) to head (85626df).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5540      +/-   ##
==========================================
- Coverage   60.98%   60.98%   -0.01%     
==========================================
  Files         796      796              
  Lines       51647    51648       +1     
==========================================
- Hits        31497    31495       -2     
- Misses      17250    17253       +3     
  Partials     2900     2900              
Flag Coverage Δ
unittests-datacatalog 69.31% <ø> (ø)
unittests-flyteadmin 58.69% <ø> (-0.05%) ⬇️
unittests-flytecopilot 17.79% <ø> (ø)
unittests-flytectl 67.50% <100.00%> (+0.05%) ⬆️
unittests-flyteidl 79.06% <ø> (ø)
unittests-flyteplugins 61.85% <ø> (ø)
unittests-flytepropeller 57.42% <ø> (ø)
unittests-flytestdlib 65.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: zychen5186 <brianchen5197@gmail.com>
@davidmirror-ops
Copy link
Contributor

@zychen5186 are you still working on this?

@zychen5186
Copy link
Contributor Author

@zychen5186 are you still working on this?

Hi @davidmirror-ops! No I’m not working on this recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants