Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the documentation about uniqueness of execution IDs #5828

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Murdock9803
Copy link

Tracking issue

Closing #4684

Why are the changes needed?

The executions has documentation about Execution and their Typical Flow. As suggested in issue #4684, there should be information about the execution IDs as well.

What changes were proposed in this pull request?

The PR simply adds an additional line in the documentation about execution IDs.

How was this patch tested?

This was a simple and straightforward Doc change, so right syntax is kept in mind and checked.

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

…t domain

Signed-off-by: Murdock9803 <ayushsahu9803@gmail.com>
@Murdock9803 Murdock9803 changed the title added the documentation about uniqueness of execution IDs in a projec… Added the documentation about uniqueness of execution IDs Oct 9, 2024
@Murdock9803
Copy link
Author

@davidmirror-ops @samhita-alla I tried to incorporate the required changes, should I change the position of added text or anything ? Please have a look at the Pull Request 🙌

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.62%. Comparing base (604be4a) to head (2d0ac2d).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (604be4a) and HEAD (2d0ac2d). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (604be4a) HEAD (2d0ac2d)
unittests-flyteadmin 1 0
unittests-flytepropeller 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5828      +/-   ##
==========================================
- Coverage   36.35%   28.62%   -7.74%     
==========================================
  Files        1304      695     -609     
  Lines      110147    66071   -44076     
==========================================
- Hits        40041    18910   -21131     
+ Misses      65939    45281   -20658     
+ Partials     4167     1880    -2287     
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin ?
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.21% <ø> (ø)
unittests-flyteidl 7.17% <ø> (ø)
unittests-flyteplugins 53.35% <ø> (ø)
unittests-flytepropeller ?
unittests-flytestdlib 55.37% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants