Fix: avoid log spam for log links generated during the pod's pending phase #5945
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
In #4726 I introduced the option to configure the lifecycle of log links as is documented here. In particular, log links can be configured to be already shown before a task starts running or be configured to disappear after a task stops.
@Tom-Newton noted that their flytepropeller logs are spammed with error messages because the log link generation logic for pod tasks checks whether container statuses exist and if not logs this as an error. Prior to #4726 it made sense to always log this as an error because log links were only generated in the "Running" phase of the task when the pod should have container statuses. Now that we optionally generate log links already in the pending phase, it is not unexpected that the container statuses are empty.
What changes were proposed in this pull request?
Log the respective message with debug log level if the pod is in the pending phase. Keep logging with error log level in other pod phases.
Check all the applicable boxes