Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs How to Improve performance of flyte #908

Closed
wants to merge 2 commits into from
Closed

Conversation

kumare3
Copy link
Contributor

@kumare3 kumare3 commented Apr 12, 2021

Signed-off-by: Ketan Umare ketan.umare@gmail.com

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
@kumare3 kumare3 changed the title Improving performance of flytepropeller Docs How to Improve performance of flyte Apr 13, 2021
Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Rule of thumb, for Flytepropeller that has 2GB or memory, should allocate about 512MB-756MB to the input/output cache.


Scaling out FlyteAdmin
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When should they scale vertically vs horizontally? maybe link to horizontal autoscaler? is there a good metric to use to scale up horizontally? Maybe request rate?

Flyteadmin is a stateless service. Often time before needing to scale FlyteAdmin, you need to scale the backing database. Check out the FlyteAdmin Dashboard to see signs of latency degredation and increase the size of backing postgres instance.
FlyteAdmin is a stateless service and its replicas (in the kubernetes deployment) can be simply increased to allow higher throughput.

Scaling out Datacatalog
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Comment on lines +17 to +19
#. Round Latency for each workflow increases
#. Transition latency increases
#. Workflows take longer to start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links to these metrics in grafana dashboard?


This is usually because the number of threads in FlytePropeller are not enough to keep up with the number of workflows. This can be resolved by adjusting FlytePropeller config specified `here <https://pkg.go.dev/github.com/flyteorg/flytepropeller@v0.10.3/pkg/controller/config>`_.

.. list-table:: Important Properties
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think for every (most of) property here, we should link to a chart that shows the effect?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how to link to a chart?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe like this

@kumare3 kumare3 closed this Jul 3, 2021
eapolinario pushed a commit to eapolinario/flyte that referenced this pull request Dec 20, 2022
* Add blog post links in documentation

Signed-off-by: 3t8 <62209650+3t8@users.noreply.github.com>

* update configuring_links (flyteorg#905)

* update configuring_links

Fixes flyteorg#2820
Signed-off-by: SmritiSatyanV smriti@union.ai

* update configuring links

Changes based on review
Signed-off-by: SmritiSatyanV smriti@union.ai
Signed-off-by: 3t8 <62209650+3t8@users.noreply.github.com>

* Update map_task.py

Signed-off-by: 3t8 <62209650+3t8@users.noreply.github.com>

* Update cookbook/integrations/external_services/airflow/README.rst

Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Signed-off-by: 3t8 <62209650+3t8@users.noreply.github.com>

* Update README.rst

Signed-off-by: 3t8 <62209650+3t8@users.noreply.github.com>

* Update dynamics.py

Signed-off-by: 3t8 <62209650+3t8@users.noreply.github.com>

* Delete configure_logging_links.py

Signed-off-by: 3t8 <62209650+3t8@users.noreply.github.com>

* Revert "Delete configure_logging_links.py"

This reverts commit 3fda83e4b19340aa930bd22624f8bb2c068031a7.

Restore configure_logging_links

Signed-off-by: 3t8 <62209650+3t8@users.noreply.github.com>

Signed-off-by: 3t8 <62209650+3t8@users.noreply.github.com>
Co-authored-by: SmritiSatyanV <94349093+SmritiSatyanV@users.noreply.github.com>
Co-authored-by: Samhita Alla <aallasamhita@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants