This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Only merge system defaults when querying workflow execution config for project attributes #522
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
The project-level-only matchable attribute endpoint currently merges in defaults from the server config (as this was the quickest way to get things going in light of the need to expose this to the UI and the complexity of the broader settings project). There was a bug in the initial implementation though - these system level defaults should only be merged when the user is querying for workflow execution configs. This just adds a check for that.
See the original PR for more info as well.
Type
Are all requirements met?
Complete description
Also update some the default config.yaml to work with the new single-binary based demo sandbox.
Tracking Issue
Just noticed this in testing.