Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Infer GOOS and GOARCH from environment #550

Merged
merged 3 commits into from
Apr 12, 2023
Merged

Infer GOOS and GOARCH from environment #550

merged 3 commits into from
Apr 12, 2023

Conversation

jeevb
Copy link
Contributor

@jeevb jeevb commented Apr 11, 2023

No description provided.

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #550 (4232ca6) into master (eb695b1) will increase coverage by 1.47%.
The diff coverage is n/a.

❗ Current head 4232ca6 differs from pull request most recent head 85a06c6. Consider uploading reports for the commit 85a06c6 to get more accurate results

@@            Coverage Diff             @@
##           master     #550      +/-   ##
==========================================
+ Coverage   58.85%   60.32%   +1.47%     
==========================================
  Files         170      170              
  Lines       16068    13155    -2913     
==========================================
- Hits         9457     7936    -1521     
+ Misses       5777     4385    -1392     
  Partials      834      834              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 156 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
wild-endeavor
wild-endeavor previously approved these changes Apr 11, 2023
@jeevb
Copy link
Contributor Author

jeevb commented Apr 12, 2023

On cr.flyte.org/flyteorg/flyteadmin:v1.1.88:

/ # uname -a
Linux 21b6acdfe975 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 Linux
/ # file $(which flyteadmin)
/bin/flyteadmin: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, Go BuildID=bXwiSig6e-aRnfeAUHXn/PvgXMiXsSS47C7sgkYFE/a_vHl8mBZ4xrHPFYqAdf/QcJHy1ljZVPSgMyqnH3a, stripped

On this PR:

/ # uname -a
Linux d713f5625740 5.15.49-linuxkit #1 SMP PREEMPT Tue Sep 13 07:51:32 UTC 2022 aarch64 Linux
/ # file $(which flyteadmin)
/bin/flyteadmin: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, Go BuildID=6MohvwQ0BeTDGfVQFvD9/N3dvqq_5MZegg_3L5DWS/VL2IRTqVOpvMr3yHaMEv/eSVES-Shgn_ajqTnj2V7, stripped

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
wild-endeavor
wild-endeavor previously approved these changes Apr 12, 2023
@jeevb jeevb marked this pull request as ready for review April 12, 2023 04:26
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
@jeevb jeevb merged commit 97a6aa4 into master Apr 12, 2023
@jeevb jeevb deleted the jeev/multiarch branch April 12, 2023 17:44
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* Infer GOOS and GOARCH from environment

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>

* Multiarch builds for flytescheduler

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>

* fix makefile to read variables from environment and overrides

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>

---------

Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants