Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Fix list named entities #609

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Fix list named entities #609

merged 1 commit into from
Sep 1, 2023

Conversation

iaroslav-ciupin
Copy link
Contributor

@iaroslav-ciupin iaroslav-ciupin commented Sep 1, 2023

TL;DR

Fix list named entity metadata endpoint.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.62% 🎉

Comparison is base (b3177ef) 58.68% compared to head (c9806d3) 60.30%.

❗ Current head c9806d3 differs from pull request most recent head 9475168. Consider uploading reports for the commit 9475168 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #609      +/-   ##
==========================================
+ Coverage   58.68%   60.30%   +1.62%     
==========================================
  Files         171      171              
  Lines       16477    13446    -3031     
==========================================
- Hits         9670     8109    -1561     
+ Misses       5955     4485    -1470     
  Partials      852      852              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/common/sorting.go 100.00% <ø> (ø)
pkg/manager/impl/util/filters.go 73.07% <ø> (+3.56%) ⬆️
pkg/repositories/gormimpl/common.go 67.85% <ø> (+12.85%) ⬆️

... and 155 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iaroslav-ciupin iaroslav-ciupin merged commit 1df2d18 into master Sep 1, 2023
14 checks passed
@iaroslav-ciupin iaroslav-ciupin deleted the fix-ci-failures branch September 1, 2023 13:23
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants