Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Reduce a warning to info #612

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Reduce a warning to info #612

merged 1 commit into from
Sep 13, 2023

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Sep 13, 2023

People have been complaining that this is too verbose. This is not actually a warning, it's just that no overrides have been set.

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
@wild-endeavor wild-endeavor changed the title reduce warning to info Reduce warning to info Sep 13, 2023
@wild-endeavor wild-endeavor changed the title Reduce warning to info Reduce a warning to info Sep 13, 2023
@wild-endeavor wild-endeavor marked this pull request as ready for review September 13, 2023 16:31
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: +1.55% 🎉

Comparison is base (df88d23) 59.01% compared to head (54c79b7) 60.57%.

❗ Current head 54c79b7 differs from pull request most recent head 088ed00. Consider uploading reports for the commit 088ed00 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
+ Coverage   59.01%   60.57%   +1.55%     
==========================================
  Files         171      171              
  Lines       16468    13442    -3026     
==========================================
- Hits         9719     8142    -1577     
+ Misses       5899     4450    -1449     
  Partials      850      850              
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/manager/impl/util/resources.go 91.52% <0.00%> (+0.85%) ⬆️

... and 157 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wild-endeavor wild-endeavor enabled auto-merge (squash) September 13, 2023 16:38
@wild-endeavor wild-endeavor merged commit 7df815d into master Sep 13, 2023
10 of 11 checks passed
@wild-endeavor wild-endeavor deleted the lower-no-overrides branch September 13, 2023 16:47
eapolinario pushed a commit that referenced this pull request Sep 28, 2023
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants