fix: use one-based day of week for aws cron expressions #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #120 +/- ##
=======================================
Coverage 70.74% 70.74%
=======================================
Files 387 387
Lines 6516 6516
Branches 1049 1049
=======================================
Hits 4610 4610
Misses 1906 1906
Continue to review full report at Codecov.
|
katrogan
approved these changes
Nov 14, 2020
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Nov 14, 2020
## [0.17.5](http://github.com/lyft/flyteconsole/compare/v0.17.4...v0.17.5) (2020-11-14) ### Bug Fixes * use one-based day of week for aws cron expressions ([#120](http://github.com/lyft/flyteconsole/issues/120)) ([1cc0e1c](http://github.com/lyft/flyteconsole/commit/1cc0e1c5629af875ede6ac9b6d84f83df2cb5ac3))
|
🎉 This PR is included in version 0.17.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Closed
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Fixed a display issue for AWS-style cron expressions using an integer day-of-week field. We need to parse those expressions using a one-based index.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#616
Follow-up issue
NA