Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improved data fetching for execution details page #131

Merged
merged 13 commits into from
Jan 6, 2021
Merged

feat: improved data fetching for execution details page #131

merged 13 commits into from
Jan 6, 2021

Commits on Jan 5, 2021

  1. refactor: integrate react-query for execution data fetching (#123) 

    * refactor: using react-query to load top level Execution

* refactor: upgrading react-query and fixing execution termination

* refactor: handle 401s on queries and do auth flow

* refactor: adding conditional refresh for execution status

* refactor: cleanup broken files after context refactor

* chore: docs
    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    09eb922 View commit details
    Browse the repository at this point in the history

  2. refactor: Remove ExecutionDataCache in favor of react-query (#126) 

    * refactor: first step of using queries for NE table

* refactor: removing data cache from first layer of NE table

* refactor: removing remaining execution data cache usage

* refactor: rename QueryKey type and remove bug workaround

* refactor: fixing remaining consumers of NEs
    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    705303e View commit details
    Browse the repository at this point in the history

  3. test: adds setup for mock-service-worker (#127) 

    * test: add msw and basic handlers for a few types

* test: add mock data for a basic workflow execution

* test: fixing/removing tests after adding msw

* test: throw on unexpected requests to msw

* fix: upgrade TS to fix error and cleanup resulting errors
    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    b881bcf View commit details
    Browse the repository at this point in the history

  4. Migrate from TSLint to ESLint (#128) 

    * ci: move from tslint->eslint

* fix: addressing eslint errors

* fix: remove passing of unused variable

* ci: remove unnecessary prettier config
    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    3f0427e View commit details
    Browse the repository at this point in the history

  5. refactor: clean up mock fixtures and re-enable tests for executions (#… 

    …130)

* test: adding test data for node executions

* test: mocks and refactoring to re-enable NodeExecutionDetails tests

* chore: lint error

* test: getting first test for NE table working again

* test: mocks and a couple of tests for NE table

* refactor: msw handlers to use a backing map and return 404s

* test: more tests for NE table

* test: adding fixture for dynamic external workflow

* test: using mock fixture for sub workflow tests

* test: move remaining mocks to fixtures and fix tests

* test: re-enabling more execution tests

* fix: removing global query handlers for caching entitiesq

* test: re-enable ExecutionNodeViews tests

* fix: typo in import path

* fix: show DataError by default for failed queries

* chore: documentation

* chore: pr feedback
    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    ee998d4 View commit details
    Browse the repository at this point in the history

  6. test: fixing storybook rendering for NE table

    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    c99d1cb View commit details
    Browse the repository at this point in the history

  7. refactor: queries and loading states for (Task)ExecutionDetails

    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    8146296 View commit details
    Browse the repository at this point in the history

  8. chore: cleanup unused code

    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    5ff0502 View commit details
    Browse the repository at this point in the history

  9. fix: adds mock support for launch plans

    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    190f258 View commit details
    Browse the repository at this point in the history

  10. test: update LoadingSpinner tests

    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    85440e8 View commit details
    Browse the repository at this point in the history

  11. fix: handle error case for NE children

    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    2dd7710 View commit details
    Browse the repository at this point in the history

  12. chore: remove todo

    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    84c292c View commit details
    Browse the repository at this point in the history

  13. fix: typo

    @schottra
    schottra committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    52c00ed View commit details
    Browse the repository at this point in the history