Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add advanced options to launch workflow form #226

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

govalt
Copy link
Contributor

@govalt govalt commented Oct 11, 2021

TL;DR

Added advanced options to launch workflow form.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Add advanced options for launching workflow forms

  • Role selection
  • Disable notifications
  • Max parallelism
  • Quality of Service

Tracking Issue

fixes flyteorg/flyte#1484

Follow-up issue

NA

Signed-off-by: csirius <85753828+csirius@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Oct 11, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@c55d508). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #226   +/-   ##
=========================================
  Coverage          ?   63.60%           
=========================================
  Files             ?      364           
  Lines             ?     7863           
  Branches          ?     1375           
=========================================
  Hits              ?     5001           
  Misses            ?     2862           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c55d508...274d463. Read the comment docs.

Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - will push hotfix right after this.

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.29.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anrusina anrusina deleted the execution-launch-form-enhancement branch January 13, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI Feature] Provide a service account or iam role at execution time.
3 participants