Code

Launch enhancements#33

Code

Merged

schottra merged 22 commits intomasterflyteorg/flyteconsole:masterfrom launch-enhancementsflyteorg/flyteconsole:launch-enhancementsCopy head branch name to clipboardJan 8, 2020

+1,547-250

Commits

Commits on Dec 16, 2019

• Creating story for collection input types

  schottra

  committed
  030d7d7

  Copy full SHA for 030d7d7

• Adding collection input component

  schottra

  committed
  6ae3d69

  Copy full SHA for 6ae3d69

• Refactoring input converters to handle lists correctly

  schottra

  committed
  c1519d7

  Copy full SHA for c1519d7

Commits on Dec 17, 2019

• Adding story for nested collections and fixing collection parsing when JSON.parse is used

  schottra

  committed
  4142892

  Copy full SHA for 4142892

Commits on Dec 18, 2019

• Tests for input conversion and some bug fixes

  schottra

  committed
  04619c4

  Copy full SHA for 04619c4

• Re-arranging tests

  schottra

  committed
  fafaa8d

  Copy full SHA for fafaa8d

• Merge pull request #30 from lyft/more-input-types

  Show description for ad6a545
  schottra

  authored
  ad6a545

  Copy full SHA for ad6a545

• Reorganizing input converters into helpers and adding validation logic

  schottra

  committed
  6809a9f

  Copy full SHA for 6809a9f

Commits on Dec 19, 2019

• Wiring up validation of inputs and showing errors during submission

  schottra

  committed
  cf07797

  Copy full SHA for cf07797

• Changing the way validation works so we don't generate a form error

  schottra

  committed
  ff0fbec

  Copy full SHA for ff0fbec

Commits on Dec 20, 2019

• Breaking up input components/state to make it easier to track value/validation changes while editing

  schottra

  committed
  e3df7d9

  Copy full SHA for e3df7d9

• Only show errors after first submission, fixing closure bugs with input values

  schottra

  committed
  9f18b5f

  Copy full SHA for 9f18b5f

• Cleanup

  schottra

  committed
  78d9db2

  Copy full SHA for 78d9db2

• Merge pull request #31 from lyft/launch-errors

  Show description for 363864f
  schottra

  authored
  363864f

  Copy full SHA for 363864f

• Setting up tests for launch form

  schottra

  committed
  320c2b2

  Copy full SHA for 320c2b2

• Adding some more tests, fixing a module import error

  schottra

  committed
  dac3858

  Copy full SHA for dac3858

Commits on Dec 21, 2019

• Notes for later

  schottra

  committed
  ee4cd0c

  Copy full SHA for ee4cd0c

Commits on Jan 6, 2020

• Adding tests for incremental state of form when loading values

  schottra

  committed
  462fb18

  Copy full SHA for 462fb18

Commits on Jan 7, 2020

• Adding remaining tests for launch form

  schottra

  committed
  de2ea33

  Copy full SHA for de2ea33

• Filling in remaining validators and test cases

  schottra

  committed
  b9bba8c

  Copy full SHA for b9bba8c

• Fixing error messages

  schottra

  committed
  4c9e533

  Copy full SHA for 4c9e533

Commits on Jan 8, 2020

• Merge pull request #32 from lyft/launch-tests

  Show description for e71b6b7
  schottra

  authored
  e71b6b7

  Copy full SHA for e71b6b7