-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 'Only Mine' toggle for execution tasks list #335
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🥳, haven't performed smoke test yet.
Let me know when you will be ready for final review
onlyMyExecutionsFilterState?: { | ||
onlyMyExecutionsValue: boolean; | ||
isFilterDisabled: boolean; | ||
onOnlyMyExecutionsFilterChange: (filterOnlyMyExecutions: boolean) => void; | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: create a separate type/interface for onlyMyState, to use here as:
onlyMyExecutionsFilterState?: OnlyMyState;
for better readability
Signed-off-by: olga-union <olga@union.ai>
Signed-off-by: olga-union <olga@union.ai>
3cf1f96
to
816f1ec
Compare
describe.each` | ||
isFilterDisabled | initialValue | expected | ||
${undefined} | ${undefined} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: false }} | ||
${false} | ${undefined} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: false }} | ||
${true} | ${undefined} | ${{ isFilterDisabled: true, onlyMyExecutionsValue: false }} | ||
${undefined} | ${false} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: false }} | ||
${undefined} | ${true} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: true }} | ||
${false} | ${false} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: false }} | ||
${false} | ${true} | ${{ isFilterDisabled: false, onlyMyExecutionsValue: true }} | ||
${true} | ${false} | ${{ isFilterDisabled: true, onlyMyExecutionsValue: false }} | ||
${true} | ${true} | ${{ isFilterDisabled: true, onlyMyExecutionsValue: true }} | ||
`('for each case', ({ isFilterDisabled, initialValue, expected }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initially wrote this up as individual tests, but thought this may be a good use case to digest them as a table. I have the original code handy, so wouldn't be a problem to revert, if it's just my taste :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any particular taste, but curious how it will look like if one of them fails?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anrusina only failed cases will show up, like in this screenshot, test case title is customized on line 26, and I just stringified expected
to show value instead of [Object Object]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Signed-off-by: Olga Nad <olga@union.ai>
…o olga-union/add-only-my-executions-filter
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
==========================================
+ Coverage 65.14% 65.16% +0.02%
==========================================
Files 390 390
Lines 8707 8699 -8
Branches 1506 1504 -2
==========================================
- Hits 5672 5669 -3
+ Misses 3035 3030 -5
Continue to review full report at Codecov.
|
Signed-off-by: Olga Nad <olga@union.ai>
Signed-off-by: olga-union <olga@union.ai> Signed-off-by: Olga Nad <olga@union.ai>
Signed-off-by: olga-union <olga@union.ai> Signed-off-by: Olga Nad <olga@union.ai>
Signed-off-by: Olga Nad <olga@union.ai>
Signed-off-by: Olga Nad <olga@union.ai>
* feat: added RawOutputDataConfig in ExecutionSpec Signed-off-by: Kevin Su pingsutw@apache.org Signed-off-by: Olga Nad <olga@union.ai>
# [0.46.0](http://github.com/lyft/flyteconsole/compare/v0.45.0...v0.46.0) (2022-03-18) ### Features * added RawOutputDataConfig in ExecutionSpec #patch ([#329](http://github.com/lyft/flyteconsole/issues/329)) ([24bdaee](http://github.com/lyft/flyteconsole/commit/24bdaeefcf32c079d1aaeb54b28cc6bf7395b42f)) Signed-off-by: Olga Nad <olga@union.ai>
Signed-off-by: Olga Nad <olga@union.ai>
Signed-off-by: Olga Nad <olga@union.ai>
Signed-off-by: Olga Nad <olga@union.ai>
…thub.com/flyteorg/flyteconsole into add-only-my-executions-filter
Type
Are all requirements met?
Description
Closed in favor of #343
Added
Only my executions
filter, removed old filter, removed unused fields on theFilterState
, updatedUserProfile
type field to match API data object. Added tests, updated storybook.Demos
https://user-images.githubusercontent.com/101579322/159072610-f54bc16d-688b-4a64-bc04-5dd3339ca4fd.mov
https://user-images.githubusercontent.com/101579322/159072616-156479d1-99d8-4e73-8df5-ff5e083531c4.mov
https://user-images.githubusercontent.com/101579322/159072621-d2a056ba-891d-4c0d-b527-fd74339ed35f.mov