Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add localStorage for selected Project/Domain #774

Merged
merged 13 commits into from
Jun 22, 2023

Conversation

jsonporter
Copy link
Contributor

@jsonporter jsonporter commented Jun 16, 2023

This PR will provide a way to store certain default behaviors/values in localStorage. Specifically, this allows users to save a users last selected project and domain from the project select UI so that subsequent visits will default to those values and skip the need to select project/domain.

  • Saves users last selected project/domain in localStorage; will skip the project select UI if value exists in localStorage
  • Adds a new "View all projects" link in the project-select dropdown (in left-nav)
  • Changes project select URL to /select-project
  • User intents captured:
    1. User selects from project select view
    2. User select from project select drop-down (in side-nav)

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Follow-up issue

NA

Signed-off-by: Jason Porter <jason@union.ai>
@jsonporter jsonporter marked this pull request as draft June 16, 2023 20:35
jsonporter and others added 7 commits June 16, 2023 13:36
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Frank Flitton <fflitton@gmail.com>
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Frank Flitton <fflitton@gmail.com>
Signed-off-by: Frank Flitton <fflitton@gmail.com>
@FrankFlitton FrankFlitton requested a review from ursucarina June 20, 2023 21:37
@ursucarina
Copy link
Contributor

the arrow is still tripping me. how do we feel about something like this @jsonporter @FrankFlitton
image

Signed-off-by: Jason Porter <jason@union.ai>
@jsonporter jsonporter marked this pull request as ready for review June 22, 2023 21:33
Signed-off-by: Frank Flitton <fflitton@gmail.com>
@FrankFlitton FrankFlitton changed the title WIP: Add localStorage for selected Project/Domain Add localStorage for selected Project/Domain Jun 22, 2023
@jsonporter jsonporter merged commit 007e636 into master Jun 22, 2023
@jsonporter jsonporter deleted the json/local-storage-context branch June 22, 2023 23:07
@jsonporter jsonporter changed the title Add localStorage for selected Project/Domain feat: Add localStorage for selected Project/Domain Jun 22, 2023
@FrankFlitton FrankFlitton restored the json/local-storage-context branch June 23, 2023 18:12
@FrankFlitton FrankFlitton deleted the json/local-storage-context branch June 23, 2023 18:14
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants