-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add localStorage for selected Project/Domain #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Frank Flitton <fflitton@gmail.com>
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Frank Flitton <fflitton@gmail.com>
Signed-off-by: Frank Flitton <fflitton@gmail.com>
the arrow is still tripping me. how do we feel about something like this @jsonporter @FrankFlitton |
ursucarina
reviewed
Jun 21, 2023
ursucarina
reviewed
Jun 21, 2023
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Frank Flitton <fflitton@gmail.com>
ursucarina
approved these changes
Jun 22, 2023
🎉 This PR is included in version 1.8.6 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will provide a way to store certain default behaviors/values in
localStorage
. Specifically, this allows users to save a users last selectedproject
anddomain
from the project select UI so that subsequent visits will default to those values and skip the need to select project/domain./select-project
Type
Are all requirements met?
Complete description
Follow-up issue
NA