This repository has been archived by the owner on May 31, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 83
Added option to update labels & description in project #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
yindia
requested review from
EngHabu,
kumare3 and
wild-endeavor
as code owners
January 9, 2022 16:15
Signed-off-by: Yuvraj <code@evalsocket.dev>
Codecov Report
@@ Coverage Diff @@
## master #260 +/- ##
==========================================
+ Coverage 76.17% 80.26% +4.08%
==========================================
Files 106 97 -9
Lines 2695 3516 +821
==========================================
+ Hits 2053 2822 +769
+ Misses 528 472 -56
- Partials 114 222 +108
Continue to review full report at Codecov.
|
…bels Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
yindia
changed the title
Feature/labels
Added option to update labels & description in project
Jan 9, 2022
Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
yindia
commented
Jan 10, 2022
Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
yindia
commented
Jan 12, 2022
EngHabu
previously approved these changes
Jan 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks fine to me but it is considered a breaking change because we are removing flags that would work today... Ideally we only deprecate these flags and delete them in a future update... otherwise we should include breaking change notice in the release notes
pmahindrakar-oss
previously approved these changes
Jan 21, 2022
Signed-off-by: Yuvraj <code@evalsocket.dev>
…ature/labels Signed-off-by: Yuvraj <code@evalsocket.dev>
Signed-off-by: Yuvraj <code@evalsocket.dev>
yindia
force-pushed
the
feature/labels
branch
from
January 23, 2022 10:47
60c4f45
to
913322c
Compare
Signed-off-by: Yuvraj <code@evalsocket.dev>
pmahindrakar-oss
previously approved these changes
Jan 24, 2022
Signed-off-by: Yuvraj <code@evalsocket.dev>
yindia
force-pushed
the
feature/labels
branch
from
January 24, 2022 08:10
549669e
to
ed1b053
Compare
pmahindrakar-oss
approved these changes
Jan 24, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
--activateProject
--archiveProject
to--activate --archive
Test:
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#1873
flyteorg/flyte#1620
Follow-up issue
NA
OR
https://github.com/flyteorg/flyte/issues/