Skip to content
This repository has been archived by the owner on Oct 23, 2023. It is now read-only.

Revert Getversion method from put to get #116

Merged
merged 2 commits into from
Mar 15, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions gen/pb-cpp/flyteidl/service/admin.pb.cc

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

368 changes: 184 additions & 184 deletions gen/pb-go/flyteidl/service/admin.pb.go

Large diffs are not rendered by default.

10 changes: 1 addition & 9 deletions gen/pb-go/flyteidl/service/admin.pb.gw.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 1 addition & 15 deletions gen/pb-go/flyteidl/service/admin.swagger.json
Original file line number Diff line number Diff line change
Expand Up @@ -2746,7 +2746,7 @@
}
},
"/api/version": {
"put": {
"get": {
"description": "Retrieve the Version (including the Build information) for FlyteAdmin service",
"operationId": "GetVersion",
"responses": {
Expand All @@ -2757,16 +2757,6 @@
}
}
},
"parameters": [
{
"name": "body",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/adminGetVersionRequest"
}
}
],
"tags": [
"AdminService"
]
Expand Down Expand Up @@ -3393,10 +3383,6 @@
"default": "MINUTE",
"description": "Represents a frequency at which to run a schedule."
},
"adminGetVersionRequest": {
"type": "object",
"title": "Empty request for GetVersion"
},
"adminGetVersionResponse": {
"type": "object",
"properties": {
Expand Down
3 changes: 1 addition & 2 deletions gen/pb-go/flyteidl/service/flyteadmin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ Class | Method | HTTP request | Description
*AdminServiceApi* | [**GetTask**](docs/AdminServiceApi.md#gettask) | **Get** /api/v1/tasks/{id.project}/{id.domain}/{id.name}/{id.version} |
*AdminServiceApi* | [**GetTaskExecution**](docs/AdminServiceApi.md#gettaskexecution) | **Get** /api/v1/task_executions/{id.node_execution_id.execution_id.project}/{id.node_execution_id.execution_id.domain}/{id.node_execution_id.execution_id.name}/{id.node_execution_id.node_id}/{id.task_id.project}/{id.task_id.domain}/{id.task_id.name}/{id.task_id.version}/{id.retry_attempt} |
*AdminServiceApi* | [**GetTaskExecutionData**](docs/AdminServiceApi.md#gettaskexecutiondata) | **Get** /api/v1/data/task_executions/{id.node_execution_id.execution_id.project}/{id.node_execution_id.execution_id.domain}/{id.node_execution_id.execution_id.name}/{id.node_execution_id.node_id}/{id.task_id.project}/{id.task_id.domain}/{id.task_id.name}/{id.task_id.version}/{id.retry_attempt} |
*AdminServiceApi* | [**GetVersion**](docs/AdminServiceApi.md#getversion) | **Put** /api/version |
*AdminServiceApi* | [**GetVersion**](docs/AdminServiceApi.md#getversion) | **Get** /api/version |
*AdminServiceApi* | [**GetWorkflow**](docs/AdminServiceApi.md#getworkflow) | **Get** /api/v1/workflows/{id.project}/{id.domain}/{id.name}/{id.version} |
*AdminServiceApi* | [**GetWorkflowAttributes**](docs/AdminServiceApi.md#getworkflowattributes) | **Get** /api/v1/workflow_attributes/{project}/{domain}/{workflow} |
*AdminServiceApi* | [**ListActiveLaunchPlans**](docs/AdminServiceApi.md#listactivelaunchplans) | **Get** /api/v1/active_launch_plans/{project}/{domain} |
Expand Down Expand Up @@ -95,7 +95,6 @@ Class | Method | HTTP request | Description
- [AdminExecutionTerminateResponse](docs/AdminExecutionTerminateResponse.md)
- [AdminFixedRate](docs/AdminFixedRate.md)
- [AdminFixedRateUnit](docs/AdminFixedRateUnit.md)
- [AdminGetVersionRequest](docs/AdminGetVersionRequest.md)
- [AdminGetVersionResponse](docs/AdminGetVersionResponse.md)
- [AdminLabels](docs/AdminLabels.md)
- [AdminLaunchPlan](docs/AdminLaunchPlan.md)
Expand Down
13 changes: 2 additions & 11 deletions gen/pb-go/flyteidl/service/flyteadmin/api/swagger.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2416,19 +2416,13 @@ paths:
schema:
$ref: "#/definitions/adminWorkflow"
/api/version:
put:
get:
tags:
- "AdminService"
description: "Retrieve the Version (including the Build information) for FlyteAdmin\
\ service"
operationId: "GetVersion"
parameters:
- in: "body"
name: "body"
required: true
schema:
$ref: "#/definitions/adminGetVersionRequest"
x-exportParamName: "Body"
parameters: []
responses:
200:
description: "A successful response."
Expand Down Expand Up @@ -3741,9 +3735,6 @@ definitions:
- "HOUR"
- "DAY"
default: "MINUTE"
adminGetVersionRequest:
type: "object"
title: "Empty request for GetVersion"
adminGetVersionResponse:
type: "object"
properties:
Expand Down
7 changes: 2 additions & 5 deletions gen/pb-go/flyteidl/service/flyteadmin/api_admin_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -2021,13 +2021,12 @@ func (a *AdminServiceApiService) GetTaskExecutionData(ctx context.Context, idNod
AdminServiceApiService
Retrieve the Version (including the Build information) for FlyteAdmin service
* @param ctx context.Context - for authentication, logging, cancellation, deadlines, tracing, etc. Passed from http.Request or context.Background().
* @param body

@return AdminGetVersionResponse
*/
func (a *AdminServiceApiService) GetVersion(ctx context.Context, body AdminGetVersionRequest) (AdminGetVersionResponse, *http.Response, error) {
func (a *AdminServiceApiService) GetVersion(ctx context.Context) (AdminGetVersionResponse, *http.Response, error) {
var (
localVarHttpMethod = strings.ToUpper("Put")
localVarHttpMethod = strings.ToUpper("Get")
localVarPostBody interface{}
localVarFileName string
localVarFileBytes []byte
Expand Down Expand Up @@ -2058,8 +2057,6 @@ func (a *AdminServiceApiService) GetVersion(ctx context.Context, body AdminGetVe
if localVarHttpHeaderAccept != "" {
localVarHeaderParams["Accept"] = localVarHttpHeaderAccept
}
// body params
localVarPostBody = &body
r, err := a.client.prepareRequest(ctx, localVarPath, localVarHttpMethod, localVarPostBody, localVarHeaderParams, localVarQueryParams, localVarFormParams, localVarFileName, localVarFileBytes)
if err != nil {
return localVarReturnValue, nil, err
Expand Down

This file was deleted.

4 changes: 2 additions & 2 deletions gen/pb-go/flyteidl/service/openapi.go

Large diffs are not rendered by default.

16 changes: 8 additions & 8 deletions gen/pb-java/flyteidl/service/Admin.java

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions gen/pb_python/flyteidl/service/admin_pb2.py

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions gen/pb_python/flyteidl/service/flyteadmin/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ Class | Method | HTTP request | Description
*AdminServiceApi* | [**get_task**](docs/AdminServiceApi.md#get_task) | **GET** /api/v1/tasks/{id.project}/{id.domain}/{id.name}/{id.version} |
*AdminServiceApi* | [**get_task_execution**](docs/AdminServiceApi.md#get_task_execution) | **GET** /api/v1/task_executions/{id.node_execution_id.execution_id.project}/{id.node_execution_id.execution_id.domain}/{id.node_execution_id.execution_id.name}/{id.node_execution_id.node_id}/{id.task_id.project}/{id.task_id.domain}/{id.task_id.name}/{id.task_id.version}/{id.retry_attempt} |
*AdminServiceApi* | [**get_task_execution_data**](docs/AdminServiceApi.md#get_task_execution_data) | **GET** /api/v1/data/task_executions/{id.node_execution_id.execution_id.project}/{id.node_execution_id.execution_id.domain}/{id.node_execution_id.execution_id.name}/{id.node_execution_id.node_id}/{id.task_id.project}/{id.task_id.domain}/{id.task_id.name}/{id.task_id.version}/{id.retry_attempt} |
*AdminServiceApi* | [**get_version**](docs/AdminServiceApi.md#get_version) | **PUT** /api/version |
*AdminServiceApi* | [**get_version**](docs/AdminServiceApi.md#get_version) | **GET** /api/version |
*AdminServiceApi* | [**get_workflow**](docs/AdminServiceApi.md#get_workflow) | **GET** /api/v1/workflows/{id.project}/{id.domain}/{id.name}/{id.version} |
*AdminServiceApi* | [**get_workflow_attributes**](docs/AdminServiceApi.md#get_workflow_attributes) | **GET** /api/v1/workflow_attributes/{project}/{domain}/{workflow} |
*AdminServiceApi* | [**list_active_launch_plans**](docs/AdminServiceApi.md#list_active_launch_plans) | **GET** /api/v1/active_launch_plans/{project}/{domain} |
Expand Down Expand Up @@ -143,7 +143,6 @@ Class | Method | HTTP request | Description
- [AdminExecutionTerminateResponse](docs/AdminExecutionTerminateResponse.md)
- [AdminFixedRate](docs/AdminFixedRate.md)
- [AdminFixedRateUnit](docs/AdminFixedRateUnit.md)
- [AdminGetVersionRequest](docs/AdminGetVersionRequest.md)
- [AdminGetVersionResponse](docs/AdminGetVersionResponse.md)
- [AdminLabels](docs/AdminLabels.md)
- [AdminLaunchPlan](docs/AdminLaunchPlan.md)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
from flyteadmin.models.admin_execution_terminate_response import AdminExecutionTerminateResponse
from flyteadmin.models.admin_fixed_rate import AdminFixedRate
from flyteadmin.models.admin_fixed_rate_unit import AdminFixedRateUnit
from flyteadmin.models.admin_get_version_request import AdminGetVersionRequest
from flyteadmin.models.admin_get_version_response import AdminGetVersionResponse
from flyteadmin.models.admin_labels import AdminLabels
from flyteadmin.models.admin_launch_plan import AdminLaunchPlan
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2377,45 +2377,43 @@ def get_task_execution_data_with_http_info(self, id_node_execution_id_execution_
_request_timeout=params.get('_request_timeout'),
collection_formats=collection_formats)

def get_version(self, body, **kwargs): # noqa: E501
def get_version(self, **kwargs): # noqa: E501
"""get_version # noqa: E501

Retrieve the Version (including the Build information) for FlyteAdmin service # noqa: E501
This method makes a synchronous HTTP request by default. To make an
asynchronous HTTP request, please pass async_req=True
>>> thread = api.get_version(body, async_req=True)
>>> thread = api.get_version(async_req=True)
>>> result = thread.get()

:param async_req bool
:param AdminGetVersionRequest body: (required)
:return: AdminGetVersionResponse
If the method is called asynchronously,
returns the request thread.
"""
kwargs['_return_http_data_only'] = True
if kwargs.get('async_req'):
return self.get_version_with_http_info(body, **kwargs) # noqa: E501
return self.get_version_with_http_info(**kwargs) # noqa: E501
else:
(data) = self.get_version_with_http_info(body, **kwargs) # noqa: E501
(data) = self.get_version_with_http_info(**kwargs) # noqa: E501
return data

def get_version_with_http_info(self, body, **kwargs): # noqa: E501
def get_version_with_http_info(self, **kwargs): # noqa: E501
"""get_version # noqa: E501

Retrieve the Version (including the Build information) for FlyteAdmin service # noqa: E501
This method makes a synchronous HTTP request by default. To make an
asynchronous HTTP request, please pass async_req=True
>>> thread = api.get_version_with_http_info(body, async_req=True)
>>> thread = api.get_version_with_http_info(async_req=True)
>>> result = thread.get()

:param async_req bool
:param AdminGetVersionRequest body: (required)
:return: AdminGetVersionResponse
If the method is called asynchronously,
returns the request thread.
"""

all_params = ['body'] # noqa: E501
all_params = [] # noqa: E501
all_params.append('async_req')
all_params.append('_return_http_data_only')
all_params.append('_preload_content')
Expand All @@ -2430,10 +2428,6 @@ def get_version_with_http_info(self, body, **kwargs): # noqa: E501
)
params[key] = val
del params['kwargs']
# verify the required parameter 'body' is set
if ('body' not in params or
params['body'] is None):
raise ValueError("Missing the required parameter `body` when calling `get_version`") # noqa: E501

collection_formats = {}

Expand All @@ -2447,8 +2441,6 @@ def get_version_with_http_info(self, body, **kwargs): # noqa: E501
local_var_files = {}

body_params = None
if 'body' in params:
body_params = params['body']
# HTTP header `Accept`
header_params['Accept'] = self.api_client.select_header_accept(
['application/json']) # noqa: E501
Expand All @@ -2461,7 +2453,7 @@ def get_version_with_http_info(self, body, **kwargs): # noqa: E501
auth_settings = [] # noqa: E501

return self.api_client.call_api(
'/api/version', 'PUT',
'/api/version', 'GET',
path_params,
query_params,
header_params,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
from flyteadmin.models.admin_execution_terminate_response import AdminExecutionTerminateResponse
from flyteadmin.models.admin_fixed_rate import AdminFixedRate
from flyteadmin.models.admin_fixed_rate_unit import AdminFixedRateUnit
from flyteadmin.models.admin_get_version_request import AdminGetVersionRequest
from flyteadmin.models.admin_get_version_response import AdminGetVersionResponse
from flyteadmin.models.admin_labels import AdminLabels
from flyteadmin.models.admin_launch_plan import AdminLaunchPlan
Expand Down
Loading