This repository has been archived by the owner on Oct 23, 2023. It is now read-only.
Add output prefix to LaunchPlanSpec #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumare3
reviewed
Jul 29, 2020
| core.QualityOfService quality_of_service = 16; | ||
|
|
||
| // Prefix for where offloaded data from user workflows will be written (ie Blobs, Schema, query data, etc.) | ||
| string output_data_prefix = 17; |
There was a problem hiding this comment.
can we keep the naming consistent? call it raw_outputdata_prefix
In the docstring it can be, of the format
s3://bucket/key OR s3://bucket/
There was a problem hiding this comment.
sure but what's raw about it?
added 2 commits
July 29, 2020 14:44
kumare3
reviewed
Jul 30, 2020
|
|
||
| // Prefix for where offloaded data from user workflows will be written (i.e. Blobs, Schema, query data, etc.) | ||
| // e.g. s3://bucket/key or s3://bucket/ | ||
| string raw_output_data_prefix = 17; |
There was a problem hiding this comment.
on thinking more, maybe this should be a structure. As we may want to add the policy like
Sharding desired: True
etc...
There was a problem hiding this comment.
what else would go in?
eapolinario
pushed a commit
that referenced
this pull request
Sep 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Please replace this text with a description of what this PR accomplishes.
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#211
Follow-up issue
NA