Child only resource discovery #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 |
honnix
commented
Nov 4, 2022
| @@ -42,6 +45,9 @@ class ChildFirstClassLoader extends URLClassLoader { | |||
| private static final String[] PARENT_FIRST_PACKAGE_PREFIXES = | |||
| new String[] {"org.flyte.api.v1.", "org.flyte.jflyte.api."}; | |||
|
|
|||
| private static final Set<String> CHILD_ONLY_RESOURCES = | |||
There was a problem hiding this comment.
This project is still targeting Java 8, so no factory method from Set to use.
honnix
force-pushed
the
skip-parent-slf4j-resource
branch
6 times, most recently
from
8bbc509 to
c044752
Compare
honnix
requested review from
narape and
RRap0so
and removed request for
narape
honnix
force-pushed
the
skip-parent-slf4j-resource
branch
4 times, most recently
from
01e38ef to
66bafbd
Compare
Signed-off-by: Hongxin Liang <honnix@users.noreply.github.com>
honnix
force-pushed
the
skip-parent-slf4j-resource
branch
from
66bafbd to
bfdf6f6
Compare
RRap0so
approved these changes
Nov 8, 2022
|
I don't have permission to merge. Maybe I should be added to some team? |
|
Congrats on merging your first pull request! 🎉 |
2 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Configure child only resource discovery to avoid discovering certain resources across class loaders.
Type
Are all requirements met?
Complete description
For certain resources such as
org/slf4j/impl/StaticLoggerBinder.class, it does not make sense to discovery a parent one because it will almost certain cause classloading problem when mixing parent class and child class.Tracking Issue
Closes flyteorg/flyte#3051
Follow-up issue
NA