Skip to content

Commit

Permalink
fix PipelineModel transformer issue 3648 (#1623)
Browse files Browse the repository at this point in the history
Signed-off-by: esad <esad@peridotml.io>
  • Loading branch information
peridotml authored May 8, 2023
1 parent ca46761 commit 35bb556
Showing 1 changed file with 4 additions and 10 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import pathlib
from typing import Type

from pyspark.ml import PipelineModel
Expand All @@ -24,22 +23,17 @@ def to_literal(
python_type: Type[PipelineModel],
expected: LiteralType,
) -> Literal:
local_path = ctx.file_access.get_random_local_path()
pathlib.Path(local_path).parent.mkdir(parents=True, exist_ok=True)
python_val.save(local_path)

# Must write to remote directory
remote_dir = ctx.file_access.get_random_remote_directory()
ctx.file_access.upload_directory(local_path, remote_dir)
python_val.write().overwrite().save(remote_dir)

return Literal(scalar=Scalar(blob=Blob(uri=remote_dir, metadata=BlobMetadata(type=self._TYPE_INFO))))

def to_python_value(
self, ctx: FlyteContext, lv: Literal, expected_python_type: Type[PipelineModel]
) -> PipelineModel:
local_dir = ctx.file_access.get_random_local_directory()
ctx.file_access.download_directory(lv.scalar.blob.uri, local_dir)

return PipelineModel.load(local_dir)
remote_dir = lv.scalar.blob.uri
return PipelineModel.load(remote_dir)


TypeEngine.register(PySparkPipelineModelTransformer())

0 comments on commit 35bb556

Please sign in to comment.