Skip to content

Commit

Permalink
Remove special case to handle 0
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
  • Loading branch information
eapolinario committed Feb 4, 2022
1 parent 6295118 commit bb98e76
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 7 deletions.
5 changes: 1 addition & 4 deletions flytekit/models/array_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,7 @@ def to_dict(self):
min_success_ratio=self.min_success_ratio,
)

array_job_dict = _json_format.MessageToDict(array_job)
if self.parallelism is not None and self.parallelism == 0:
array_job_dict['parallelism'] = '0'
return array_job_dict
return _json_format.MessageToDict(array_job)

@classmethod
def from_dict(cls, idl_dict):
Expand Down
5 changes: 2 additions & 3 deletions tests/flytekit/unit/core/test_map_task.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,6 @@ def test_serialization(serialization_settings):
task_spec = get_serializable(OrderedDict(), serialization_settings, maptask)

# By default all map_task tasks will have their custom fields set.
assert task_spec.template.custom["parallelism"] == "0"
assert task_spec.template.custom["minSuccessRatio"] == 1.0
assert task_spec.template.type == "container_array"
assert task_spec.template.task_type_version == 1
Expand Down Expand Up @@ -100,9 +99,9 @@ def test_serialization(serialization_settings):
@pytest.mark.parametrize(
"custom_fields_dict, expected_custom_fields",
[
({}, {"parallelism": "0", "minSuccessRatio": 1.0}),
({}, {"minSuccessRatio": 1.0}),
({"concurrency": 99}, {"parallelism": "99", "minSuccessRatio": 1.0}),
({"min_success_ratio": 0.271828}, {"parallelism": "0", "minSuccessRatio": 0.271828}),
({"min_success_ratio": 0.271828}, {"minSuccessRatio": 0.271828}),
({"concurrency": 42, "min_success_ratio": 0.31415}, {"parallelism": "42", "minSuccessRatio": 0.31415}),
],
)
Expand Down

0 comments on commit bb98e76

Please sign in to comment.