-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add missing secret_requests to ContainerTask #1307
add missing secret_requests to ContainerTask #1307
Conversation
Signed-off-by: Felix Ruess <felix.ruess@roboception.de>
Codecov Report
@@ Coverage Diff @@
## master #1307 +/- ##
==========================================
- Coverage 68.87% 68.85% -0.02%
==========================================
Files 287 287
Lines 26429 26436 +7
Branches 2495 2498 +3
==========================================
+ Hits 18202 18203 +1
- Misses 7743 7748 +5
- Partials 484 485 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
So while with this I can inject secrets into my container "the flyte way", it doesn't quite do what I expected/need. |
@flixr - the flytekit |
@wild-endeavor yeah, I used |
Merging this for now... thanks! Can you make a new issue in the flyte repo and just copy in your last comment? I'm going to ask around and see what can be done. It does feel a bit weird that we're prepending seemingly random characters to the env var. Just curious though, wrt this env var specifically, you're going with secrets instead of linking up iam roles to the eks service accounts? |
I'm not running on EKS, but on my on-prem k3s cluster and how would I even change the service account used for my tasks? |
Signed-off-by: Felix Ruess felix.ruess@roboception.de
TL;DR
add missing secret_requests to ContainerTask
Type
Are all requirements met?
Complete description
Do the same as in other container tasks...
Tracking Issue
Follow-up issue
NA