Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove requirements files #1511

Merged
merged 8 commits into from
Feb 17, 2023
Merged

Remove requirements files #1511

merged 8 commits into from
Feb 17, 2023

Conversation

eapolinario
Copy link
Collaborator

TL;DR

Remove mentions to requirements.txt and dev-requirements.txt

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Up to this point we operated under the assumption that maintaining a single set of requirements files would be enough. This would guarantee a semblance of reproducibility (since we would be able to reproduce the environment used for that change). That assumption broke down as we started seeing libraries not being available in all OS+architecture we support, for example, tensorflow does not install cleanly on Mac M1's.

In this change we trade reproducibility for the maintenance burden of having exhaustive requirements files by environment. jazzband/pip-tools#826 (comment) is the current advice coming from pip-tools, basically if we are to do this we need to run pip-tools once per-environment.

Instead, we're taking one step back in order to figure out what's the right next steps. The idea is that we're going to invest in a real multi-environment solution in the near future, but in the meanwhile, we're going to lose reproducibility in order to decrease the maintenance burden. Note that this change is going to subsume the need for #1424.

As a side-note, we removed the legacy all-spark extras in #807, but never removed the CI bits related to the spark-2.4 extra. Those are being removed in this PR.

Tracking Issue

flyteorg/flyte#3284

Follow-up issue

NA

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 17, 2023

Codecov Report

Merging #1511 (b2db3eb) into master (74cbe58) will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1511      +/-   ##
==========================================
+ Coverage   69.31%   69.34%   +0.02%     
==========================================
  Files         305      305              
  Lines       28657    28642      -15     
  Branches     2714     2310     -404     
==========================================
- Hits        19864    19861       -3     
+ Misses       8276     8266      -10     
+ Partials      517      515       -2     
Impacted Files Coverage Δ
flytekit/core/promise.py 51.96% <0.00%> (-0.57%) ⬇️
flytekit/clis/flyte_cli/main.py 44.34% <0.00%> (ø)
flytekit/extras/persistence/http.py 24.48% <0.00%> (ø)
flytekit/types/directory/__init__.py 0.00% <0.00%> (ø)
flytekit/types/schema/types.py 38.30% <0.00%> (+0.15%) ⬆️
flytekit/models/security.py 13.15% <0.00%> (+0.33%) ⬆️
flytekit/types/file/file.py 61.11% <0.00%> (+0.42%) ⬆️
flytekit/types/directory/types.py 56.19% <0.00%> (+0.46%) ⬆️
flytekit/configuration/internal.py 18.46% <0.00%> (+2.02%) ⬆️
flytekit/interfaces/random.py 25.00% <0.00%> (+5.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

This reverts commit 50cbb4d.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
This reverts commit eae945c.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
@eapolinario eapolinario merged commit 99d3d50 into master Feb 17, 2023
eapolinario added a commit that referenced this pull request Feb 28, 2023
* Remove mentions to spark

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove mentions to requirements.txt and dev-requirements.txt

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove plugins requirements.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove all_requirements target from plugins makefile

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Use dev-requirements.in in lint gh action job

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Remove all_requirements target from plugins makefile"

This reverts commit 50cbb4d.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Remove plugins requirements."

This reverts commit eae945c.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario added a commit that referenced this pull request Feb 28, 2023
* Remove mentions to spark

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove mentions to requirements.txt and dev-requirements.txt

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove plugins requirements.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove all_requirements target from plugins makefile

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Use dev-requirements.in in lint gh action job

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Remove all_requirements target from plugins makefile"

This reverts commit 50cbb4d.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Remove plugins requirements."

This reverts commit eae945c.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
eapolinario added a commit that referenced this pull request Feb 28, 2023
…pgrade (#1458) (#1525)

* Flytekit Auth system overhaul and pretty printing upgrade (#1458)

* [wip] New authentication system

 - Reuse local keyring better
 - use grpc based auth system

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* Better error handling and printing, better exception handling and
retrying

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* Delete legacy files

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* add missing None

Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.home>

* keyring removed

Signed-off-by: Ketan Umare <ketanumare@Ketans-MacBook-Pro.local>

* added insecure_skip_verify

Signed-off-by: Ketan Umare <ketanumare@Ketans-MacBook-Pro.local>

* test fixed

Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI>

* Test fixed

Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI>

* Auth update

Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI>

* updated test

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* updated

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* flush buffer instead of closing, was getting a weird stack trace. make the image smaller

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* updated ca-cert logic

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* Fixed unit tests

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* updated

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* test fix

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* updated

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* nest raise if exc

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>

* added keyring.alt for tests

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* updated

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* updated

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>

* Lint

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.home>
Signed-off-by: Ketan Umare <ketanumare@Ketans-MacBook-Pro.local>
Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Ketan Umare <ketanumare@Ketans-MBP.home>
Co-authored-by: Ketan Umare <ketanumare@Ketans-MacBook-Pro.local>
Co-authored-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI>
Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove requirements files (#1511)

* Remove mentions to spark

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove mentions to requirements.txt and dev-requirements.txt

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove plugins requirements.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove all_requirements target from plugins makefile

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Use dev-requirements.in in lint gh action job

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Remove all_requirements target from plugins makefile"

This reverts commit 50cbb4d.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Remove plugins requirements."

This reverts commit eae945c.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove requirements files (#1511)

* Remove mentions to spark

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove mentions to requirements.txt and dev-requirements.txt

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove plugins requirements.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Remove all_requirements target from plugins makefile

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Use dev-requirements.in in lint gh action job

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Remove all_requirements target from plugins makefile"

This reverts commit 50cbb4d.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

* Revert "Remove plugins requirements."

This reverts commit eae945c.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>

---------

Signed-off-by: Ketan Umare <ketan.umare@gmail.com>
Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.home>
Signed-off-by: Ketan Umare <ketanumare@Ketans-MacBook-Pro.local>
Signed-off-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI>
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Ketan Umare <16888709+kumare3@users.noreply.github.com>
Co-authored-by: Ketan Umare <ketanumare@Ketans-MBP.home>
Co-authored-by: Ketan Umare <ketanumare@Ketans-MacBook-Pro.local>
Co-authored-by: Ketan Umare <ketanumare@Ketans-MBP.UNION.AI>
Co-authored-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Co-authored-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants