Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically remove unused import #1574

Merged
merged 2 commits into from
Apr 3, 2023
Merged

Automatically remove unused import #1574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec7f946
Automatically remove unused import
pingsutw Apr 2, 2023
33755a0
nit
pingsutw Apr 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ setup: install-piptools ## Install requirements

.PHONY: fmt
fmt: ## Format code with black and isort
autoflake --remove-all-unused-imports --ignore-init-module-imports --ignore-pass-after-docstring --in-place -r flytekit plugins tests
pre-commit run black --all-files || true
pre-commit run isort --all-files || true

Expand Down
1 change: 1 addition & 0 deletions dev-requirements.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,4 @@ scikit-learn
types-protobuf
types-croniter
types-mock
autoflake
1 change: 0 additions & 1 deletion flytekit/clis/flyte_cli/main.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1167,7 +1167,6 @@ def terminate_execution(host, insecure, cause, urn=None):
raise _click.UsageError('Missing option "-u" / "--urn" or missing pipe inputs.')
except KeyboardInterrupt:
_sys.stdout.flush()
pass
else:
_terminate_one_execution(client, urn, cause)

Expand Down
1 change: 0 additions & 1 deletion flytekit/core/tracker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,6 @@ def find_lhs(self) -> str:
# Since dataframes aren't registrable entities to begin with we swallow any errors they raise and
# continue looping through m.
logger.warning("Caught ValueError {} while attempting to auto-assign name".format(err))
pass

logger.error(f"Could not find LHS for {self} in {self._instantiated_in}")
raise _system_exceptions.FlyteSystemException(f"Error looking for LHS in {self._instantiated_in}")
Expand Down