Nested Subworkflow #203
Merged
Nested Subworkflow #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| input_literal_map = _literal_models.LiteralMap(literals=kwargs) | ||
|
|
||
| outputs_literal_map = self.dispatch_execute(ctx, input_literal_map) |
There was a problem hiding this comment.
So i know this was done in another PR, when you removed the stupid BaseExecutor thing, but it harkens back to this discussion here: https://lyft.slack.com/archives/GAG9AAS9K/p1600964346001300 - where we were discussing whether a) tasks knew how to execute themselves b) they relied on an executor to execute them.
I feel like we all seemed inclined at the time to go with the latter option - you kinda wrote something like it in the google doc https://docs.google.com/document/d/1nJprPSZtxbXQLoafD2xeN0JIueHnEb6TNIsJiXHF6rY/edit
We're sure we're okay with this change? This is the right thing to do?
| @workflow | ||
| def my_wf(a: int, b: str) -> (int, str, str): | ||
| x, y = t1(a=a) | ||
| u, v = my_subwf(a=x) |
There was a problem hiding this comment.
Do you end up with two node-0's in the current scheme?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.