Implements a brand new type engine #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 21, 2020 14:22
- Type engine is now pluggable. - Contributors can now add new types to flytekit, just using the register method TODO, all transformations should go through this type engine.
kumare3
requested review from
matthewphsmith and
wild-endeavor
as code owners
wild-endeavor
approved these changes
Oct 23, 2020
added 4 commits
October 22, 2020 21:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Enables transforming a python native type to Literal and vice versa, while always maintaining the expected python type.
Also enables introduction of new python types easily, as long as they can be converted to a flyte backend type.
This also introduces a change in the task heirarchy
Taskis purely deals in flyte abstract models - TypedInterfacePythonTaskis represents every task that has a python native types based interface. It is responsible in upconverting the types to Base Task