Simple Schema type support -> pandas dataframe #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2020 20:29
kumare3
requested review from
matthewphsmith and
wild-endeavor
as code owners
flytekit/annotated/workflow.py
Outdated
| # Length check, clean up exception | ||
| raise Exception(f"Length difference {len(output_names)} {len(function_outputs)}") | ||
| elif len(output_names) == 1 and isinstance(function_outputs, Promise): | ||
| return function_outputs |
There was a problem hiding this comment.
is the stuff below not needed?
There was a problem hiding this comment.
what do you mean? its like elif right? the indentation here looks weird, but seems fine in the code
There was a problem hiding this comment.
But it returns here right, so the stuff below won't run. Should it not run? I added some Promise renaming stuff but maybe it's not needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new pandas dataframe transformer. This results in a generic schema