[ignore] Annotations - file typing #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wild-endeavor
requested review from
kumare3 and
matthewphsmith
as code owners
wild-endeavor
commented
Oct 25, 2020
flytekit/annotated/workflow.py
Outdated
| @@ -152,6 +152,9 @@ def _local_execute(self, ctx: FlyteContext, **kwargs) -> Union[Tuple[Promise], P | |||
| else: | |||
| raise Exception("something returned from wf but shouldn't have outputs") | |||
|
|
|||
| if len(output_names) == 1: | |||
There was a problem hiding this comment.
Ran into this bug too - will just take your change, whatever we decide on.
kumare3
reviewed
Oct 26, 2020
kumare3
reviewed
Oct 26, 2020
| if item not in mimetypes.types_map and f".{item}" not in mimetypes.types_map: | ||
| raise Exception(f"{item} not a valid extension according to mimetypes.") | ||
|
|
||
| class _SpecificFormatClass(FlyteFilePath): |
There was a problem hiding this comment.
Why? you really hate TypeVar?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for ketan/haytham
test_type_hintsfile over into the annotated test dir.