Annotations limit urllib3 #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wild-endeavor
commented
Nov 11, 2020
•
wild-endeavor
commented
- Changed setup.py to limit urllib3 to <1.26.0. That version has been giving users issues since it was released yesterday.
- Ran make requirements.
- Nit changes to tests
wild-endeavor
requested review from
kumare3 and
matthewphsmith
as code owners
kumare3
reviewed
Nov 11, 2020
| numpy==1.19.2 # via flytekit, pandas, pyarrow | ||
| pandas==1.1.3 # via flytekit | ||
| papermill==2.2.0 # via flytekit | ||
| nest-asyncio==1.4.2 # via nbclient |
There was a problem hiding this comment.
no clue, child of papermill apparently
kumare3
approved these changes
Nov 11, 2020
This was referenced Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.